christian-thiele / datahub Goto Github PK

When docker build has an error, only verbose mode shows failure, non-verbose just shows "running" indefinitely.

lat var not initialized when no config variable for environment exists

base_broker_api_service.dart:50
initializeFanOutExchange

missing line:
_channels.add(channel);

Problem arises when using invalid field names inside the default dto constructor or when unmapping dao objects.
Invalid fields or wrong types are possible.
-> Security issue!

make fields and databean safer by using a type constraint

Allow users to define a base path at the ApiBase (like /api/v1)

cookies

ServiceHost -> ApplicationHost
remove dependency comment in pubspec.yaml
remove exit(0); from main

Rethrow results in exception being printed twice, once by logservice, once not. Also, servicehost is not able to shutdown services in this case.

Instead: show exception through logservice, shutdown gracefully and end application with error code.

some way to configure custom certificates for amqp service

Decode route params like query params at Route.getParam

lists are typed with YamlList which does not match List when querying config values.
not convenient

Dao type can then be inferred for methods like query(DataLayout) etc. to prevent the Invalid dao type "dynamic" bug in client code.

Shortcut for
resolve<ConfigService>().environment

import 'some_dto.dart' as some;

@TransferObject()
class MyDto extends _TransferObject {
    final some.SomeDto child;

    MyDto(this.child);
}

Generated code does not use named type which results in compile time error.

property authProvider in ApiService is legacy, not used

// TODO while we escape values, we don't need to worry about substitution values // TODO but that's probably not the best way, lets think of some sort of system that // TODO let's us use substitutions without clashing names // @CTH by CTH: maybe provide a "namespace" to methods like this to avoid // clashing names?

See sql_builder.dart

Current config design pattern is not suitable for config files most commonly used in cloud native environments

equals / notEquals is a nice pattern, other CompareTypes are not included tho. results in a lot of tedious code

Officially host dart_amqp fork for datahub and use it in datahub.
Features include:

• Named connections
• AutoDelete Exchanges (deprecated in amqp, but still needed in some cases for rabbitmq)

"Missing value" is not always helpful

• Use extended interface for parameter names (BrokerApi and BrokerInterface could possibly define different param names which leads to serialization errors)
• Use queueName and durable from BrokerInterface to avoid collision

Config / Param fetching could be the same pattern

Add PropertyCompareType.In that checks if field value is in list.

SQL: field in ( , , , )

It can be confusing that generated code (BrokerApi) has a "hidden" dependency on amqp lib.
This should be exported by broker.dart to avoid multiple necessary imports

Check if it would be benefitial to constraint the TData type on HubResource types to the specific TransferObjectBase.

Pro:

• cannot mess up id-types and produce run time errors
• ...
  Contra:
• TData would be limited to TransferObjectBase
• ...

"native" JWT parse / verify / issue utilities

Not really needed for modern use cases

Database transaction support.
Method call on connection with delegate.
If delegate throws, rollback. Maybe also add cancellation token or something?
Maybe no need to throw, can be call on callback but lets see

desired log level can not yet be configured (everything is printed by LogService)

Request body data should be streamed so that large files can be rejected by header data or size or whatever inside the request handler!

Use TransferObjectBase instead of TransferObjectBase
Use
void getId() {}

instead of
Null getId() => null;

insert
// ignore_for_file: constant_identifier_names
into dto.g.dart files

Logging is currently done using print statements across the code.
Ugly af

'Basic ' instead of 'Bearer '

Migrations should use transactions to not leave database in irrecoverable state after migration failed somewhere

Dto fields and enum values are serialized by field name. Breaking dart field name conventions is not a good practice when wanting to set other serialization values. Provide annotation stuff.

Probably an error in ValueExpression with List / Iterable types

Because of security, internal error causes are not sent to the client. In debug mode this should be different to make debugging easier.

in datahub test cli command check if docker-compose file exists, if not treat like --no-compose

Check for datahub config often throws (caught) exceptions that are annoying when debugging.
Check before fetching and avoid exceptions.

request.requestedUri in api_service.dart:71 can throw if uri is invalid, replace or catch

If present

Only options right now are getParam / getParamInt.

Should be getParam() with proper codec

-> ACK

"Failed to create socket" exceptions are unhandled!
Catch in ApiService.initialize