christian-draeger / increment-semantic-version Goto Github PK

Is it possible to have a version-fragment defined as pre, which is in-between the beta and rc stages?

The feature has crossed the beta stage but not yet has the potential to be called a release candidate (RC). In this case, this is required to be marked as pre-release.

If not already supported, request to kindly consider adding this as a feature.

As in https://semver.org/ stated a pre-release (alpha, beta, rc) is appended by a series of dot-separated identifiers:

<pre-release> ::= <dot-separated pre-release identifiers>
<dot-separated build identifiers> ::= <build identifier>
                                    | <build identifier> "." <dot-separated build identifiers>

Currently pre-releases are not separated with dot-separated identifiers. So instead of 2.11.7-rc1 it should be 2.11.7-rc.1

Hi

Thanks @christian-draeger for your excellent work on this action. Simple yet effective solution to a common annoyance of setting up automatic versioning.

I quickly noticed that I need to be able to add build number to the version string, so I added the needed logic for that in a forked repo (TLii/increment-semantic-version-with-build-data). All changes are (should be) non-breaking.

Before I open a pull request, do you see this as a feature that should or could be added to the upstream, or shall I keep it a separate fork?

There is a bug in the action. When executing an alpha, beta or rc release on a non-alpha/non-beta/non-rc release (e.g. 0.14.0) the preversion variable is null. Therefore the script will fail with the following message:

##[error]Docker run failed with exit code 1

I wrote a tiny script copying the behavior:

#!/usr/bin/bash -l

prev_version="$1"; releaseType="$2"

# break down the version number into it's components
regex="^([0-9]+).([0-9]+).([0-9]+)((-[a-z]+)([0-9]+))?$"
if [[ $prev_version =~ $regex ]]; then
  major="${BASH_REMATCH[1]}"
  minor="${BASH_REMATCH[2]}"
  build="${BASH_REMATCH[3]}"
  pre="${BASH_REMATCH[5]}"
  preversion="${BASH_REMATCH[6]}"
else
  echo "previous version '$prev_version' is not a symantic version"
  exit 1
fi

echo "major is $major"
echo "minor is $minor"
echo "build is $build"
echo "pre is $pre"
echo "preversion is $preversion"

Executing . ./testregex.sh 0.14.0 alpha results in:

major is
minor is
build is
pre is
preversion is

Hi,
I'm trying for some time now to make the incremental versioning automatic by passing the previous version to the plugin as the current_version, but it keeps giving the error "previous version '$ENV' is not a semantic version.
I made sure that the value of environment variable (ENV) is actually a valid semantic version (1.0.6) by printing it in different steps.
Is there anything I need to know regarding this issue?

It seems there is bug in version 1.0.1.
If use action like this

      - name: Bump release version
        id: bump_version2
        uses: christian-draeger/[email protected]
        with:
          current-version: '1.15.2-alpha4'
          version-fragment: 'alpha'

then result will be:

Run christian-draeger/[email protected]
  with:
    current-version: 1.15.2-alpha4
    version-fragment: alpha
create alpha-release version: 1.15.2-alpha4 -> 1.15.2-alpha1

The same for beta and rc

Hi!

Would it be possible to add support for versions that have a v in front? Would be great!

I tried this by passing v1.5.0 but that fails with

previous version 'v1.5.0' is not a semantic version

Hi,

if tested many actions and could not get anything really working without a hassle except for this one, thank you.

It seems to require to s specify the current version manually and does not fetch it from the tags automatically. So if you make changes, you need to set the currentVersion manually, otherwise this action will do nothing.

Am I missing something or is this really how it works?

I was using this action (version 1.1.0) in other workflow and it worked fine, but now with the same version I see no output from action.
If you have some thoughts on it please tell me, what could cause this strange behavior.
I attached screenshot with logs of step bump-version (it seems to be ok) and the result of echo ${{ toJSON(steps) }}