Code Monkey home page Code Monkey logo

Comments (4)

chris-prener avatar chris-prener commented on September 17, 2024 1

Thanks @edzer - we want to make sure lwgeom is installed because we use sf::st_area in the package. So while we don't import anything directly, it is a necessary dependency that isn't installed automatically by sf. At least that is how I am thinking about it - am I off base there?

With tibble - my understanding is that if a package prints an object as a tibble but the user does not have tibble installed, there are issues with printing the object. So therefore safter to require tibble as a dependency? Again, would love your perspective here.

Thanks for the feedback!

from areal.

edzer avatar edzer commented on September 17, 2024

st_area is in sf, and sf only class lwgeom stuff if the data are in geodetic coordinates, which is often not the case, so you don't actually need it, and sf will tell you when you need it. tibble is a dependency of dplyr, so comes automatically when you import dplyr.

If CRAN has no problems with what you do, then I also don't.

from areal.

chris-prener avatar chris-prener commented on September 17, 2024

We put it in when we were testing the package and were prompted to install lwgeom by sf. I'll revisit whether it is necessary, though. CRAN had no problems.

from areal.

chris-prener avatar chris-prener commented on September 17, 2024

have removed lwgeom (shouldn't be needed since projected coords required by functions) and tibble (which should be installed along with dplyr)

from areal.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.