Code Monkey home page Code Monkey logo

Comments (13)

gep13 avatar gep13 commented on July 22, 2024

@Redsandro said...
Got this comment in an email (however I don't see it on disqus):

It could be that the comment was deleted, or that the comment is sitting in the moderation queue. There should be a note to that effect in the email that you received.

from chocolatey-packages.

Redsandro avatar Redsandro commented on July 22, 2024

New version of PaleMoon browser, Gunnersson reported in again with the same problem.

Cannot index into a null array.
palemoon\tools\Get-UrlFromFosshub.ps1 line 13 char 3

Is someone able to run a 64 bit vm? Perhaps there's a difference between 64 and 32 bit. It used to work but I've not been able to test on 64 bit arch, which reporter used.

from chocolatey-packages.

Redsandro avatar Redsandro commented on July 22, 2024

cinst palemoon -debug

image

This scrolls like the matrix when trying to learn something from -debug.
I am not Neo, this isn't helping. :neckbeard:
@TomOne do you have any suggestions?

from chocolatey-packages.

TomOne avatar TomOne commented on July 22, 2024

The error was caused by accessing a non-array here: https://github.com/chocolatey/chocolatey-coreteampackages/blob/86b9fa09890ef0a40cbb288f4d3be6fd874537ac/automatic/palemoon/tools/Get-UrlFromFosshub.ps1#L12-L13

The 32-bit URL of the package (http://relmirror.palemoon.org/release/palemoon-25.3.2.win32.installer.exe) is not a FossHub-URL, so there were no regex matches.

I made the function more robust when used with non-FossHub URLs: ff484e0

The fixed package is released: https://chocolatey.org/packages/palemoon/25.3.2.20150501

@Redsandro, that matrix-style scrolling is the UTF-8 representation of the binary exe file downloaded from http://relmirror.palemoon.org/release/palemoon-25.3.2.win32.installer.exe, which the function downloaded in https://github.com/chocolatey/chocolatey-coreteampackages/blob/86b9fa09890ef0a40cbb288f4d3be6fd874537ac/automatic/palemoon/tools/Get-UrlFromFosshub.ps1#L20. This won’t happen again with my fix. πŸ˜„

from chocolatey-packages.

Redsandro avatar Redsandro commented on July 22, 2024

Ah thank you!

from chocolatey-packages.

i-give-up avatar i-give-up commented on July 22, 2024

I'm not sure that the function is currently working - I'm getting 403 Forbidden Error for the FossHub link.

I've posted on Pastebin a relevant snippet of the log file (I tried to attach it here but I got "we can't process that file" error). What happened is that

  • downloading the 64-bit version (hosted on FossHub) failed
  • the 32-bit version installed successfully
  • the output says "The install of palemoon was NOT successful"
  • palemoon doesn't show up when executing choco list -l

I'm thinking that it might be easier to simply use the direct relmirror.palemoon.org links. Unless there's some catch that I'm not aware of.

from chocolatey-packages.

Redsandro avatar Redsandro commented on July 22, 2024

Hi @i-give-up, sorry for getting back on this so late.

I can't work on this right now and the latency in getting PRs checked and merged in this core team packages repository is larger than my attention-span. Maintenance of my packages is in abeyance.

Do you want to take over as maintainer?

from chocolatey-packages.

i-give-up avatar i-give-up commented on July 22, 2024

Unfortunately I know too little about Chocolatey to be a package maintainer. I only started using it for about a week or so.

from chocolatey-packages.

Redsandro avatar Redsandro commented on July 22, 2024

Fair enough. Since you said 32 bit installs correctly, and 64 bit is hosted on relmirror too, I've updated ketarin to reflect your changes.

@gep13 are changes to ketarin .xml in Master automatically picked up by the ketarin machine? Or does someone need to import it?

from chocolatey-packages.

gep13 avatar gep13 commented on July 22, 2024

@Redsandro when I last looked at it, it was a manual process, but I seem to remember that @ferventcoder had a script that could be used to import the xml files from the repo on each ketarin run. Not sure if that ever got implemented or not though.

from chocolatey-packages.

Redsandro avatar Redsandro commented on July 22, 2024

@gep13 Can you do this for this palemoon package? Or who do I need to @mention?

from chocolatey-packages.

i-give-up avatar i-give-up commented on July 22, 2024

How long does this change take to propagate?

I just tried choco install palemoon again and it is still trying and failing to get the 64-bit installer from fosshub. And I'm still seeing the old chocolateyInstall.ps1 on palemoon's Chocolatey page.

from chocolatey-packages.

Redsandro avatar Redsandro commented on July 22, 2024

I have no power over this. I think @gep13 @TomOne and @ferventcoder can do this. Otherwise it will happen automatically when a new version of palemoon comes out.

from chocolatey-packages.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.