Code Monkey home page Code Monkey logo

Comments (8)

pauby avatar pauby commented on August 24, 2024 1

From a comment I saw, somebody was pointing to ungoogled-chromium for Arm64 and x86 editions. So that sounds like an alternative if somebody wants the x86 version.

I would suggest we don't switch maintainers and therefore remove the x86 build entirely from this. I'd be interested to hear from @AdmiringWorm .

from chocolatey-packages.

JPRuskin avatar JPRuskin commented on August 24, 2024

Should we stop internalizing the x86 version, and leave the x64? That'll cut size in half, and hopefully provide the best overall user experience?

from chocolatey-packages.

pauby avatar pauby commented on August 24, 2024

I'd agree with this. The precedent has been set with other packages already doing this - embed the x64, download the x86 at runtime.

from chocolatey-packages.

JPRuskin avatar JPRuskin commented on August 24, 2024

As it happens, for the source we've picked, I found this comment:

No idea about Marmaduke but as for me, I have decided to stop building 32-bit variants when Chromium dropped support for Windows 7. I can't imagine many people using 32-bit versions on Windows 10/11 and it doubles build time for each version which costs me in electricity.

There hasn't been an x86 update from that maintainer since January.

Would we prefer to change maintainer, or entirely drop x86? It seems legitimate to consider.

from chocolatey-packages.

AdmiringWorm avatar AdmiringWorm commented on August 24, 2024

I suggest keeping the x86 version still, but to have it be downloaded when needed. And only embed the 64-bit version.

The ungoogled-chromium package does not include Arm64 nor x86 editions; even if it was, it isn't equal to the standard chromium build.

from chocolatey-packages.

JPRuskin avatar JPRuskin commented on August 24, 2024

I suggest keeping the x86 version still, but to have it be downloaded when needed. And only embed the 64-bit version.

The only thing here is that the version will never match, nor be updated. I'll flip the PR over from draft, though, if that's the preference.

@corbob has also pointed out that the x86 version is present and updating in the dev stream, so removing the x86 from the regular stream would make the build a little more complex. Definitely easier to leave it in.

from chocolatey-packages.

github-actions avatar github-actions commented on August 24, 2024

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?
This issue will be closed in 14 days if it continues to be inactive.

Please do not add a comment to circumvent automatic closure unless you plan to help move it forward.
Doing this may lead to the issue being closed immediately instead.

from chocolatey-packages.

github-actions avatar github-actions commented on August 24, 2024

Dear contributor,

As this issue seems to have been inactive for quite some time now, I've automatically closed it.
If you feel this is a valid issue, please feel free to re-open the issue if/when a pull request
has been added.
Thank you for your contribution.

from chocolatey-packages.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.