chocolateapp / chocolate Goto Github PK

Hey, I was looking at the install.sh file and see that it doesn't use a virtualenv. I think it would be better to do so in case the requirements conflict with requirements elsewhere. I can open a pull request for this if so desired. I suppose it could be located under /etc/chocolate/ or maybe you have a better suggestion?

It would be incredible if different versions were named after different types of chocolate. Like for a Mac Variant can be White chocolate. Linux? Milk chocolate. Windows Could be Cookies and cream. Server version with all the fixings? Chocolate with nuts. Installer? Call that sucker the wrapper! The food based names are vast and the opportunities to exploit these are even more so.

https://peps.python.org/pep-0008/#imports is a common practice, be cool if Chocolate could adopt this.

It would make it easier for other contributors and to increase readability of the code with standard conventions.

[![wakatime](https://wakatime.com/badge/user/4cf4132a-4ced-411d-b714-67bdbdc84527/project/ecce3f45-dba9-4e4b-8f78-693c6d237d1c.svg)](https://wakatime.com/badge/user/4cf4132a-4ced-411d-b714-67bdbdc84527/project/ecce3f45-dba9-4e4b-8f78-693c6d237d1c)

link for wakatime in readme.md doesnt work
redirects to a page

Not Found
The requested URL was not found on the server. If you entered the URL manually please check your spelling and try again.

INFO:werkzeug:10.0.2.100 - - [25/Mar/2024 17:48:08] "GET /favicon.ico HTTP/1.1" 200 -
ERROR:chocolate_app:Exception on /rescan_all [POST]
Traceback (most recent call last):
  File "/home/docker/.local/lib/python3.11/site-packages/flask/app.py", line 2525, in wsgi_app
    response = self.full_dispatch_request()
               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/docker/.local/lib/python3.11/site-packages/flask/app.py", line 1822, in full_dispatch_request
    rv = self.handle_user_exception(e)
         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/docker/.local/lib/python3.11/site-packages/flask_cors/extension.py", line 165, in wrapped_function
    return cors_after_request(app.make_response(f(*args, **kwargs)))
                                                ^^^^^^^^^^^^^^^^^^
  File "/home/docker/.local/lib/python3.11/site-packages/flask/app.py", line 1820, in full_dispatch_request
    rv = self.dispatch_request()
         ^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/docker/.local/lib/python3.11/site-packages/flask/app.py", line 1796, in dispatch_request
    return self.ensure_sync(self.view_functions[rule.endpoint])(**view_args)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/docker/.local/lib/python3.11/site-packages/chocolate_app/routes/libraries.py", line 261, in rescan_all
    type_to_call[library["lib_type"]](library["lib_name"])
  File "/home/docker/.local/lib/python3.11/site-packages/chocolate_app/scans.py", line 1793, in getOthersVideos
    getOthersVideos(library, directoryPath)
  File "/home/docker/.local/lib/python3.11/site-packages/chocolate_app/scans.py", line 1799, in getOthersVideos
    print_loading(allVideos, index, title)
  File "/home/docker/.local/lib/python3.11/site-packages/chocolate_app/scans.py", line 268, in print_loading
    terminal_size = os.get_terminal_size().columns - 1
                    ^^^^^^^^^^^^^^^^^^^^^^
OSError: [Errno 25] Inappropriate ioctl for device
INFO:werkzeug:10.0.2.100 - - [25/Mar/2024 17:48:42] "POST /rescan_all HTTP/1.1" 500 -

Maybe just some clunkyness of react apps passing to chocolate.

Linux Bookworm
Personal docker build

As mentioned in #7 (comment)

I was also looking at maybe breaking it up. Maybe use this issue to reference it in the future.

When docker will get fixed?

Salut @Impre-visible! This project looks really cool!

Do you have a place where roadmap proposals are discussed?

For example, plans for non-webbrowser client support?

Rather than build new clients have you considered implementing compatible protocols so existing clients can be used unmodified? For example:

• https://github.com/jellyfin/jellyfin-kodi
• https://github.com/jellyfin/jellyfin-android
• https://github.com/croneter/PlexKodiConnect
• etc.

app.py and intro.py appear to duplicate code, for example:

• Chocolate/intro.py

  Line 39 in 9d84946

  class Series(db.Model):

• Chocolate/app.py

  Line 106 in 9d84946

  class Series(db.Model):

Hello, i just installed Choclate in a docker Container.
Everything works, but the Library Scan seems not to work.
By pressing the Button "Rescan all libraries" i receive these logs:

/mnt/video/test\Annihilation.mkv: No such file or directory
[2023-04-16 17:23:47,341] ERROR in app: Exception on /rescanAll [GET]
Traceback (most recent call last):
File "/usr/local/lib/python3.10/site-packages/flask/app.py", line 2525, in wsgi_app
response = self.full_dispatch_request()
File "/usr/local/lib/python3.10/site-packages/flask/app.py", line 1822, in full_dispatch_request
rv = self.handle_user_exception(e)
File "/usr/local/lib/python3.10/site-packages/flask_cors/extension.py", line 165, in wrapped_function
return cors_after_request(app.make_response(f(*args, **kwargs)))
File "/usr/local/lib/python3.10/site-packages/flask/app.py", line 1820, in full_dispatch_request
rv = self.dispatch_request()
File "/usr/local/lib/python3.10/site-packages/flask/app.py", line 1796, in dispatch_request
return self.ensure_sync(self.view_functions[rule.endpoint])(**view_args)
File "/usr/local/lib/python3.10/site-packages/flask_login/utils.py", line 290, in decorated_view
return current_app.ensure_sync(func)(*args, **kwargs)
File "/chocolate/app.py", line 2840, in rescanAll
getMovies(lib["libName"])
File "/chocolate/app.py", line 693, in getMovies
length = length_video(video_path)
File "/chocolate/app.py", line 1438, in length_video
return float(seconds.stdout)
ValueError: could not convert string to float: ''

is there an bug with the Path? it seems to have an "" instead of an "/".

Thanks