Code Monkey home page Code Monkey logo

Comments (4)

isopov avatar isopov commented on May 23, 2024

equals(null) seems to be a bad style on its own - for me it is better to write "== null"

from checkstyle.

isopov avatar isopov commented on May 23, 2024

Moreover - there is only two possible outcomes of this code - "equals(null)" - false and NPE.

from checkstyle.

romani avatar romani commented on May 23, 2024

yes it is not a very good but it it not different from example in Doc:

should be refactored to:

String nullString = null;
"My_Sweet_String".equals(nullString);

read it as ""My_Sweet_String".equals(null);"

so should not be a problem, just to be consistent in validation. @isopov , does it make sense ?

from checkstyle.

romani avatar romani commented on May 23, 2024

After discussion, we decided to not implement this, as null is kind of Literal, and developer have to do variable == null.

from checkstyle.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.