OpenJDK 21 Syntax Related Check Updates about checkstyle HOT 10 CLOSED

We unlikely to change default behavior to keep compatibility with previous behavior.

I tend to disagree here. We need to evolve, checks should reflect today's best practices and styles by default, not best practices from 10/15/20 years ago. Checkstyle should be leading the community in best practices.

Imagine you are a brand new user with a Java 21 project; you will need to go through a bunch of pain to configure your checks to follow modern practices. I would expect the latest version of any tool to support modern Java paradigms, with up to date syntax and and contemporary style.

On the other hand, I would also expect to have to do some minor updates to my config over the lifetime of a 15 year old project.

from checkstyle.

For unnamed variables:

One check needs to be Indentation. It has to execute on all tokens otherwise things are "hidden" from it. IllegalToken should support it, if it doesn't already.

NoWhitespace After/Before should be considered. Maybe WhitespaceAround should support it.

from checkstyle.

PatternVariableName doesn't allow unnamed variables by default.

from checkstyle.

We unlikely to change default behavior to keep compatibility with previous behavior. Please feel free to customize allowed pattern in your config. If think that it is very reasonable to have it by default , please create separate issue and share all details there.

from checkstyle.

@nrmancuso or @apflieger, please create new issue, to discuss exact code and check and reasoning of changing default.

We traditionalally keep compatibility, rather than change behavior in new releases. But in new issue it will be a way better see all details and vote on exact update.

from checkstyle.

Yup, this is issue is just a convenient place to easily drop ideas. We will analyse what we come up with here and generate comprehensive issues when the time is right.

from checkstyle.

Another issue that could be considered for this: #14825

from checkstyle.

Parenpad for record pattern def: https://checkstyle.sourceforge.io/checks/whitespace/parenpad.html#ParenPad

from checkstyle.

@mahfouz72 please confirm that we have covered all that is mentioned here in our tracker issues, then I will close this.

from checkstyle.

@nrmancuso All items mentioned here are covered by the tracker issues. We can close this issue

from checkstyle.