Comments (3)
adrianreber
commented on June 30, 2024
go-criu is pulled in via libpod and the same definitions are also part of runc. The runc version in cri-o seems to be still the old version from before runc was also using go-criu.
Not totally sure how this works in Go when multiple vendored-in projects already vendor-in the same Go code. One recommendation would be to vendor-in a newer runc into cri-o to have the same CRIU RPC definitions from go-criu in runc and libpod.
from go-criu.
adrianreber
commented on June 30, 2024
I see that you already opened a PR to update runc in cri-o. But as the latest runc version from November 2018 it does not contain the vendored-in go-criu.
from go-criu.
vrothberg
commented on June 30, 2024
I see that you already opened a PR to update runc in cri-o. But as the latest runc version from November 2018 it does not contain the vendored-in go-criu.
Thanks a lot, @adrianreber! In my desperation, I did not check the latest master of runc which I just vendored into CRI-O that is finally happy.
from go-criu.
Related Issues (20)
- rss explore for rss fails with a panic HOT 7
- Enable 'stylecheck' golangci-lint linter HOT 1
- crit: parse data fields in files.img HOT 9
- Restore shelljob in go-criu HOT 9
- CRIT: use proto names instead of camelCase in JSON HOT 7
- Make 7.1.0 release HOT 6
- Port image. functions to go
- port file i/o fucntions for go-crit HOT 1
- Tag SemVer-compatible tags to facilitate go modules HOT 11
- Unable to restore TCP_CORK (1): Operation not supported HOT 1
- make test not working HOT 3
- golang protobuf bump HOT 5
- Proposal: implement stricter merge rules HOT 14
- undefined: syscall.Socketpair and undefined: syscall.AF_LOCAL HOT 5
- tty: Don't have tty to inherit session from, aborting err:0 HOT 2
- Rework magic-gen.go into standalone script
- Remove `vendor` dir and use `go.mod` directly HOT 2
- v6.0.0 release HOT 1
- const stats.StatsDump stats.StatsRestore missing
- proto: namespace conflict with letsencrypt
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from go-criu.