I tried to run make test for this repo and it's not w

now fixed: <div class="highlight highlight-text-shell-session notranslate position

make test not working about go-criu HOT 3 CLOSED

checkpoint-restore commented on August 14, 2024

make test not working

from go-criu.

Comments (3)

rst0git commented on August 14, 2024

I have a feeling I am missing something very obvious here; please help.

checkpoint/restore of test/piggie requires root privileges.

$ sudo make test
mkdir -p image
test/piggie
Child forked, pid 325139
test/test dump `pidof piggie` image                                                                                                                   
CRIU version 31500                                                                                                                                    
Dumping                                                                                                                                               
TEST PRE DUMP                                                                                                                                         
Success                                                                                                                                               
test/test restore image                                                                                                                               
CRIU version 31500                                                                                                                                    
Restoring                                                                                                                                             
Success                                                                                                                                               
pkill -9 piggie || :

from go-criu.

kolyshkin commented on August 14, 2024

This was caused by not running tests as root, as well as lack of checking in piggie and Makefile.

All this is addressed now:

#44 test/piggie.c: handle error from clone()
93b6a6a (item 2) Fix mixing C and go files, enable golangci-lint (this is part of #46)

from go-criu.

kolyshkin commented on August 14, 2024

now fixed:

[kir@kir-rhat go-criu]$ make test
mkdir -p image
PID=$(test/piggie/piggie) && { \
test/test dump $PID image && \
test/test restore image; \
pkill -9 piggie; \
}
clone() failed: Operation not permitted
make: *** [Makefile:23: test] Error 1

(it' is more clear now that EPERM is the cause of the failure, and where it comes from)

from go-criu.

Recommend Projects