cgutteridge / graphite Goto Github PK

This bit me in the bottom in some code I was wriing. I think forceString( &$resource )should NOT be listed as part of the API and we should add a non-mutating version which does
$string_uri = $graph->FN( $resource_or_string_uri );
whithout modifying the incoming value. Not sure what to call the fn though.

Hi.

Here's what I get, trying to rebuild an archive on Debian testing :

$ ant package
Buildfile: /home/olivier/git/github.com/cgutteridge/Graphite/build.xml

package:
[exec] Error: Channel validator error: field "name" - package name "RDF Graphite" is invalid
[exec] Parsing of package.xml from file "../package.xml" failed
[exec] Cannot package, errors in package file

BUILD FAILED

wot is an RDF schema for PGP encryption, which can be found here:

http://xmlns.com/wot/0.1/

The schema itself is embedded in a comment inside the HTML (presumably this is a valid thing to do?). Graphite doesn't find the schema:

http://graphite.ecs.soton.ac.uk/browser/?uri=http%3A%2F%2Fxmlns.com%2Fwot%2F0.1%2F

Is Graphite doing the right thing by ignoring a schema that is inside a comment, or should it be fixed to support this use case?

Coverage of core apis would be beneficial.

I noticed that http://graphite.ecs.soton.ac.uk/download.php/Graphite.php seems to be absent from Git.

I think it got started from cfc4901 (which actually is the version available in http://graphite.ecs.soton.ac.uk/download.php/Graphite_and_ARC2.tgz If I'm not mistaken), and added some ARC2 config stuff.

I've committed it into https://github.com/olberger/Graphite/tree/current

P.S.: I'm trying to track such changes in order to try and produce Debian packaging

It would be nice if

$new_list = $resource_list->sort()

with no paramters just used the toString() of the list items themselves.

ex=http://example.org/ns/
term=http://example.org/ns/foo/bar

this currently shortens to ex:foo/bar but should not be. IRI should generally not have a / or # in the term.

This upgrade makes an assumption that ARC2.php is in the path. Many people using graphite will be doing so in a hacky environment without the benefits of PEAR infrastructure or the ability to modify their apache config etc.

Maybe we can we test if ARC2 is already loaded and if so not do the require_once?

based on some rules to be decided, but getting dangerously close to xpath so might be worth checking existing standards.

At the moment there's graphite-docs.html but not too much in the way of API docs.

At some point or another, we should merge the two and rely on tools like doxygen or phpdocumentor/docblox to generate it for us. This would be a good move because the documentation can appear inline in a lot of common IDEs; and we can automate generation of docs from source.

Example slick docs by phpdocumentor:
http://demo.phpdoc.org/

There may be a need to use a 'natural' sort which sorts numbers numerically so

http://id.example.org/1/foo
http://id.example.org/5/foo
http://id.example.org/11/foo

sort in that order. Alphabetic would give:

http://id.example.org/1/foo
http://id.example.org/11/foo
http://id.example.org/5/foo

I think the correct test should now be :

public function testLabel() {
$this->assertInstanceOf('Graphite_Null', $this->resource->label());

     $this->markTestIncomplete("Needs further coverage");
 }

Hope this helps

A resourceList is a list of Graphite Nodes which can include literals (and inverse relations). Maybe fix this in documentation rather than mess around with the class name?

Just adding this as a reminder, more for myself than anything else

Short version:
pirium

Longer version:
See http://blog.stuartherbert.com/php/2011/09/22/php-components-publishing-your-pear-channel-on-github/