cfpb / college-costs Goto Github PK

Since not all of the UI inputs match the calculator tool a few of the totals are incorrect.

Leading zeros are getting chopped off of school ZIPs in schoolData.zip5.

For example, Yale (IPEDS 130794) has a ZIP of 06520, but schoolData.zip5 is 6520.

From user testing: When entering a new value for private loan interest, after typing a number and a decimal point, the tool sometimes won't allow entry of a value after the decimal.

I'm seeing a console error of Uncaught TypeError: Cannot read property 'amount' of undefined if I follow these (admittedly unlikely) steps, though:

• Add a second private loan
• Remove the first private loan
• Change the value of any of the remaining private loan fields

This is related to the way the page collects information about the private loan fields, and how those fields are updated. A special operation must be added to handle a user removing a school.

Two incorrect double-equals evaluators are keeping grad rate values from populating during updates.

Addressed in

Changing program length years in the intro changes the grand total for borrowing but doesn't change the Step 1 value for "Total cost of attendance"

Because of the way we're combining values from the URL into a single field the "money your family will provide" field cannot be edited.

Hi!

The debt portion of college cost comparison tool doesn't seem to be populating. To recreate, I'm on chrome on a mac, and was comparing American University, Brown University, and Boston College.

Screenshot below!

Like the title says, "Your school" should be "This school" in all the bar graphs.

Note that there are also several references to "your school" in the non-graph content of step 2. I won't change any of those references yet, only the bar graphs for now.

When the tool is between 740 and 740 px wide (IPEDS 215062):

And between 900 and 925 pixels wide (IPEDS 215062):

Resulting in stuff like this, sometimes (at 902 pixels for IPEDS 408039):

Some schools without program data aren't displaying the graduation rate on the graduation rate graph, like iped=163976. It seems like an empty window.programData object is overwriting the school's graduation rate with an empty string in the school model.

I think refactoring getSchoolValues.getGradRate to work more like getSchoolValues.getDefaultRate should fix this bug.

The JavaScript functional (browser) tests documented here currently fail with numerous errors.

At first glance this appears to be due to a mismatch between the test data and the browser tests. For example, the browser tests load this local page:

http://localhost:8000/paying-for-college2/understanding-your-financial-aid-offer/offer/?iped=408039&pid=981&oid=f38283b5b7c939a058889f997949efa566c616c5&totl=45000&tuit=38976&hous=3000&book=650&tran=500&othr=500&pelg=1500&schg=2000&stag=2000&othg=100&ta=3000&mta=3000&gib=3000&wkst=3000&parl=14000&perl=3000&subl=15000&unsl=2000&ppl=1000&gpl=1000&prvl=3000&prvi=4.55&prvf=1.01&insl=3000&insi=4.55&inst=8

(note pid=981)

When this page is loaded, this error message is displayed instead of a functional page:

The information your school provided is missing the program ID, which is vital information for this tool to work. Please contact your school and ask them to ensure they are sending us the right program ID and it's in the correct format.

Once your school provides you with an updated URL link, you will be able to return here so you can continue reviewing the information in the tool.

The test data (which can be loaded with ./manage.py loaddata collegedata) does not include a program with program_code=981, so it fails the test here.

Looking back in the git history for this repo, the browser tests were last updated in #248 on August 4, 2016. The test data was last updated in #285 on October 11, 2016. Perhaps the tests were not updated when the test data was -- if so, the test URL will need to be updated to work properly against the current test data.

These failures were also mentioned on #322 here.

Since IDs must be unique, the code must enumerate the ID of any elements within each private loan.

Six-digit values (and negative five-digit values to a lesser degree) overlap the dollar sign in line items:

This one's totally my fault—I intentionally set the dollar sign far enough over to fit five digits plus a comma, thinking "no one's going to take out $100,000 of loans for a year!" But I forgot that we also show total debt for the entire program, which could conceivably be six digits.

Not sure what the best solution is here, but note that if we end up moving the dollar sign over for six-digit values, we'll need to check to make sure it fits across all screen sizes (the accounting column is already pretty tight for screen sizes near the smaller breakpoints).

IE10+ inserts a pseudo-element on some inputs to clear the input's value:

Those muck with our calculation JS, so we need to remove them and any other, uh, helpful input doo-dads browsers put in.

The npm test command fails because its subcommand snyk test fails with several high severity vulnerabilities:

Tested 586 dependencies for known vulnerabilities, found 20 vulnerabilities, 69 vulnerable paths.

To reproduce, first log in to Snyk using snyk auth and then run snyk test from the command line. Alternatively, you can browse the vulnerabilities through the Snyk web UI (requires membership in the "cfpb" organization).

The high severity vulnerabilities seem to come from [email protected], which is also a CFPB package from https://github.com/cfpb/student-debt-calculator. Correcting the vulnerabilities here may require a new version release of that package that corrects its vulnerabilities.

The API refactor in #118 works great for schools with program data but fails for me for schools without program data. For example: /paying-for-college2/understanding-your-financial-aid-offer/offer/?iped=234155#info-right

Since there's no program data associated with that school, some content on the page (the graphs, especially) doesn't display. I've only poked around a little, but it looks like some JS isn't getting executed in those cases. Putting a console.log at the very top of metricView.init, for instance, prints a console message for our test school with program data but not for any other school.

Overlapping graph points aren't getting de-overlapped on initial page load, resulting in graphs like this:

I think what's happening is that, since most of the page is hidden when the page loads, metricView.fixOverlap can't get the height and position values it needs to adjust the graph points.

Quickest solution seems to be calling metricView.init when the "Yes, this is correct" button is clicked. That will recalculate all the graph values with the graphs visible, which should fix all the overlaps.

I don't believe we currently have this date coming from the schools. What happens when we don't have this date?

Do we remove this text?

Do we try to calculate it based on program length and 10 year repayment term (seems like a large effort for very little affect)?

Initially, there should be three private loans in the DOM so that a NoJS scenario will show three private loans in the form.

Short description explaining the high-level reason for the new issue.

Current behavior

We received reports from EDMC that their students were getting an error message from the Paying for College Understanding Your Financial Aid Offer tool last night. They were receiving an 500 error code.

"The CFPB site appears to not be operational. We are receiving many reports of students not being able to load their exercises. For context, here is a SS of the error I am getting."

Expected behavior

That the tool would work.

Steps to replicate behavior (include URLs)

1. None provided

Screenshots

Short description explaining the high-level reason for the new issue.

Current behavior

A state AG asked us for a test URL to show to a school. When I put the URL together and tested it out the tool was displaying a number of old features that should not be shown.

For example the following should not be displayed:

1. The national average bar for graduation rates
2. A warning indicator under the debt burden calculation
3. The national average for default rates

Expected behavior

The test version should look like the current version of the tool.

Steps to replicate behavior (include URLs)

https://www.consumerfinance.gov/paying-for-college2/understanding-your-financial-aid-offer/offer/test/?iped=482477&pid=bach&leng=48&totl=81232&tuit=19948&hous=10908&book=360&tran=0&othr=6316&pelg=5815&schg=5985&stag=0&othg=0&mta=0&gib=0&wkst=0&ppl=0&parl=0&perl=0&subl=3000&unsl=6500&gpl=0&prvl=0&prvi=0&prvf=0&insl=0&insi=0inst=0&oid=9e0280139f3238cbc9702c7b0d62e5c238a835d0#info-right

Screenshots

@higs4281

@marteki and I should team up to do this.

In order to properly on-board non-settlement students we need the opening questions to the user to mirror what we currently ask on the P4C comparison tool.

1. School Name
2. "I have a financial aid offer from this school" [Not on UYFAO]
3. Program Type
4. Program Length
5. Residency- This school has different tuition/fees depending on your residency situation: [Not on UYFAO]
6. Housing situation- Where do you plan to live? [Not on UYFAO]

We need this information to properly populate the cost of attendance for a particular school.

The scenarios that will drive Javascript development for the "understanding financial aid offers" page

Separated by audience:

• Specific to settlement students
• Specific to non-settlement students
• Used by all students

The percentage for private loan fee should get prepopulated with the fee % from Grad Plus loan

Using the "Remove" button to remove a private loan fails to update the offer numbers on the page in iOS (or on my iPhone, at least).

I think it's a simple fix—looks like there's a missing bracket in enumeratePrivateLoanIDs, line 203:

$( '[data-private-loan' ).each( function() {

That should be:

$( '[data-private-loan]' ).each( function() {

Not sure why it only fails on iOS.