certusone / yubihsm-go Goto Github PK

The system was left running overnight on the latest master branch for cosmos-sdk patched with Aiakos initialization. We validated approx. 8200 blocks before the segfault.

panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x30 pc=0xcd168d]

goroutine 31 [running]:
github.com/cosmos/cosmos-sdk/vendor/github.com/certusone/yubihsm-go/securechannel.(*SecureChannel).SendEncryptedCommand(0x0, 0xc00553df58, 0x0, 0x0, 0x0, 0x0)
/home/gopath/src/github.com/cosmos/cosmos-sdk/vendor/github.com/certusone/yubihsm-go/securechannel/channel.go:184 +0x4d
github.com/cosmos/cosmos-sdk/vendor/github.com/certusone/yubihsm-go.(*SessionManager).household.func1(0xc0018a6850)
/home/gopath/src/github.com/cosmos/cosmos-sdk/vendor/github.com/certusone/yubihsm-go/manager.go:75 +0x166
github.com/cosmos/cosmos-sdk/vendor/github.com/certusone/yubihsm-go.(*SessionManager).household(0xc0018a6850)
/home/gopath/src/github.com/cosmos/cosmos-sdk/vendor/github.com/certusone/yubihsm-go/manager.go:122 +0x2b
github.com/cosmos/cosmos-sdk/vendor/github.com/certusone/yubihsm-go.NewSessionManager.func1(0xc0018a6850)
/home/gopath/src/github.com/cosmos/cosmos-sdk/vendor/github.com/certusone/yubihsm-go/manager.go:59 +0x2b
created by github.com/cosmos/cosmos-sdk/vendor/github.com/certusone/yubihsm-go.NewSessionManager
/home/gopath/src/github.com/cosmos/cosmos-sdk/vendor/github.com/certusone/yubihsm-go/manager.go:57 +0x1ce

I am creating this issue just to share, that I will be working on this feature and avoid duplicate work.

If you have any guidance opinions on how to implement this please let me know.

We need:

• integration tests (hard without an actual [mock] HSM)
• tests for the crypto implementation
• tests for the session logic
• tests for the session manager