ceriath / candelafvtt Goto Github PK

View Code? Open in Web Editor NEW

2.0 2.0 2.0 4.34 MB

Candela Obscura for Foundry (unofficial system)

License: GNU Affero General Public License v3.0

Shell 0.57% JavaScript 46.90% SCSS 19.60% Handlebars 32.93%

candelafvtt's People

Contributors

Stargazers

Watchers

Forkers

erizocosmico juraj-visnovsky

candelafvtt's Issues

Missing Illumination keys

Hello 👋, currently, we're missing Illumination keys related to the chosen Specialty.

I'd be happy to prepare a PR that adds these keys, but before I do that, I'd like to start a discussion on how this feature should work.

I believe it would make sense to include the Illumination Keys in the Specialties pack. However, I'm unsure about the level of flexibility this feature should offer for customization. Considering the openness of other features in this system, I think it makes sense to allow editing of the keys both in the Compendium pack and on the character sheet. However, I'm not entirely certain if it should be possible to change the number of Illumination keys by adding or removing them (as the Core Rulebook doesn't address this).

In summary, I would appreciate hearing your opinion on the following questions:

Should it be possible to edit Illumination keys belonging to a given Specialty in the Compendium pack?
Should it be possible to add/remove Illumination keys belonging to a given Specialty in the Compendium pack?
Should it be possible to edit Illumination keys on the character sheet?
Should it be possible to add/remove Illumination keys on the character sheet?

v12: deprecated global OperatorTerm

Error: You are accessing the global "OperatorTerm" which is now namespaced under foundry.dice.terms.OperatorTerm
Deprecated since Version 12
Backwards-compatible support will be removed in Version 14
    at Object.logCompatibilityWarning (foundry-esm.js:4605:19)
    at get (foundry-esm.js:65234:25)
    at Action.rollAction (action.mjs:32:26)

v12: deprecated globalThis.mergeObject

Error: You are accessing globalThis.mergeObject which must now be accessed via foundry.utils.mergeObject
Deprecated since Version 12
Backwards-compatible support will be removed in Version 14
    at Object.logCompatibilityWarning (foundry-esm.js:4605:19)
    at get (foundry-esm.js:65215:25)
    at get defaultOptions (actor-sheet.mjs:13:9)
    at CandelafvttActorSheet._getInheritanceChain (foundry.js:5871:23)
    at CandelafvttActorSheet._callHooks (foundry.js:5892:41)
    at CandelafvttActorSheet._getHeaderButtons (foundry.js:6052:10)
    at CandelafvttActorSheet._getHeaderButtons (foundry.js:7215:25)
    at CandelafvttActorSheet._getHeaderButtons (foundry.js:74104:25)
    at CandelafvttActorSheet._renderOuter (foundry.js:5946:27)
    at CandelafvttActorSheet._renderOuter (foundry.js:7144:30)

Problem with Drive and Atributes

Hello, first, thanks for creating this system for Foundry.

I can't change the max value of drives and attributes, as I assume the first box where you can put a number is not the max drive for exemple, because when I put any number in the box nor the other drive number change ou my resistance change.

Level up issues

Currently, I don't believe there are any options to add on circle or class-level options.
The group I am with have been playing since the first launch and has levelled once.
I managed to get around the characters drives etc by editing the class file but found no way to increase the circles resources except by adding another member.

Check boxes for equipment

Given the way equipment works in games, is there any way of implementing check boxes on the equipment to show which equipment has been selected?

If there isn’t we have a (slightly clunky) work around which works.

v12: deprecated global Die

Error: You are accessing the global "Die" which is now namespaced under foundry.dice.terms.Die
Deprecated since Version 12
Backwards-compatible support will be removed in Version 14
    at Object.logCompatibilityWarning (foundry-esm.js:4605:19)
    at get (foundry-esm.js:65234:25)
    at Action.rollAction (action.mjs:27:32)

system "candelafvtt" uses pack.private which has been replaced with pack.ownership

This system is targeting v11 foundry minimum but is using pack.private which is a v10 setting. I think in your system.json you need
"ownership": {
"PLAYER": "OBSERVER",
"TRUSTED": "OBSERVER",
"ASSISTANT": "OWNER",
"GAMEMASTER": "OWNER"
},
for private: false and you need
"ownership": {
"PLAYER": "LIMITED",
"TRUSTED": "OBSERVER",
"ASSISTANT": "OWNER",
"GAMEMASTER": "OWNER"
},
for private: true from the couple things I read. Unless you want them set with some other setting. Below is the issue I referenced
foundryvtt/foundryvtt#9318

I changed my local install and it makes the warning go away. Cheers.

restyle chat messages

I think their style should be improved, they are currently very functional but not pretty...

v12: deprecated CONST.CHAT_MESSAGE_TYPES

Error: CONST.CHAT_MESSAGE_TYPES is deprecated in favor of CONST.CHAT_MESSAGE_STYLES because the ChatMessage#type field has been renamed to ChatMessage#style
Deprecated since Version 12
Backwards-compatible support will be removed in Version 14
    at Object.logCompatibilityWarning (foundry-esm.js:4605:19)
    at Object.get (foundry-esm.js:2492:21)
    at Action.rollAction (action.mjs:59:44)

v12: deprecated Handlebars colorPicker

Error: The {{colorPicker}} Handlebars helper is deprecated and replaced by use of the <color-picker> custom HTML element
Deprecated since Version 12
Backwards-compatible support will be removed in Version 14
    at Object.logCompatibilityWarning (foundry-esm.js:4605:19)
    at Object.colorPicker (foundry.js:8245:19)
    at Object.c (handlebars.min.js:27:27865)
    at Object.eval [as main] (eval at createFunctionContext (handlebars.min.js:29:10011), <anonymous>:23:155)
    at c (handlebars.min.js:27:23534)
    at d (handlebars.min.js:27:23849)
    at e (handlebars.min.js:28:30886)
    at renderTemplate (foundry.js:7825:10)
    at async CandelafvttActorSheet._renderInner (foundry.js:5989:16)
    at async CandelafvttActorSheet._renderInner (foundry.js:6559:18)

v12: deprecated CONST.CHAT_MESSAGE_STYLES.ROLL

Error: CONST.CHAT_MESSAGE_STYLES.ROLL is deprecated in favor of defining rolls directly in ChatMessage#rolls
Deprecated since Version 12
Backwards-compatible support will be removed in Version 14
    at Object.logCompatibilityWarning (foundry-esm.js:4605:19)
    at Proxy.get (foundry-esm.js:2505:23)
    at Reflect.get (<anonymous>)
    at Object.get (foundry-esm.js:2493:22)
    at Action.rollAction (action.mjs:59:44)

v12: deprecated global AudioHelper

Error: You are accessing the global "AudioHelper" which is now namespaced under foundry.audio.AudioHelper
Deprecated since Version 12
Backwards-compatible support will be removed in Version 14
    at Object.logCompatibilityWarning (foundry-esm.js:4605:19)
    at get (foundry-esm.js:65234:25)
    at Action.rollAction (action.mjs:63:9)