cerebralfart / laravel-crud Goto Github PK

Concerns

• How is storage itself handled
• Validation
• Multiple files

Add possibility to validate changes to objects.

Functionality

• Only dirty fields should be checked
• Fields absent in the $validation-array should not be validated

Proposed Syntax

$validation = [
  'email' => 'required|email|unique:users,email',
  'password' => 'required'
];

It should be possible to check update-policies of related models.

Functionality

• The relation should be a BelongsTo-relation, HasMany could result in too many checks.
• The update policy should be checked, regardless of the action being performed (create, update, destroy)

Proposed Syntax

$touches=[
  'user'
];

Currently, the collection is available in the view as $items. It would be more appropriate to base this name on the model name, i.e. $tasks, $users, etc.

Currently, we only support "boolean" filters, either they are active or they are not. The functionality of the CRUD Controller would be improved by allowing users to pass an argument to their filters, for example to select a range of shirt sizes: _filter[size]=38-42.

If provided, the argument will be forwarded to the filter-function as a string, to prevent accidentally misinterpreting a provided value.

To prevent accidentally exposing private information, the order-columns should be whitelistable. Still unsure about what the default behaviour should be

Add the posibility for full text search.

Functionality

• Match rows against a full-text search term, much like how the current naive search works.

Proposed Syntax

Still to be determined

The current implementation of applyFilter queries the matching IDs for all active filters. This can be optimized by using a query structure like WHERE id IN (SELECT id FROM table WHERE [filter conditions]).

This should not result in any changes for the developer or end user.

The current default argument resolver uses a shallow is-not-null strategy. This is annoying when resolving data like the view in ViewHelper#view:

$chain = $this->viewMap[$name] ?? static::$defaultViewMap[$name];

Somehow, defining the viewMap should not override keys which are not present, which would allow the code above to be written as:

$chain = $this->viewMap[$name];

Currently the application throws a default \Exception. This should at least be an exception custom to the package, or preferably even custom exceptions per error condition.

As the title suggest, it should be possible to order the data-list on multiple columns

The ListAction should support pagination of results, even when filter, search and order are active.

Functionality

• Implemented using limit/offset-based pagination.
• Page can be set by the client using the _page parameter, and defaults to 1.
• Page size can be set by the client using _pageSize parameter, and defaults to the $paginationSize property.

Proposed Syntax

$paginationSize = 15;