Sometimes "elif True" if generated about unrpyc HOT 3 CLOSED

Maybe we could still change the behaviour so that the original else branch is put with comments and elif True is replaced with else to avoid confusion?

The goal of unrpyc is to replicate the input files as exact as possible. If the input file contained elif True followed by else then we should emit the same, even if it is something silly from the original author. So I don't think anything needs to be changed here.

And yeah, probably they were just trying some things and didn't want to delete the original branch just yet.

from unrpyc.

Huh. do you have an example file for this? I have seen no evidence in renpy itself for this.

Are you sure the source file didn't actually state elif True?

edit: especially as the PyExpr seems to point to the "True" being a piece of text from something in the game/scripts/quests/.. folder I'm inclined to believe someone just wrote elif True there.

from unrpyc.

This could have been something generated with a specific version RenPy as I found this file by downloading a bunch of random games, decompiling the RPAs and comparing both implementations.

So I dug a bit deeper to find out and conveniently, the original creator of this game left the original RPY files in the final game and I did found an elif True statement and then an else statement. Maybe they wanted to make this branch as some sort of comment? In that case UnRPYC did not make any mistake so I retested without my change and it seems like the behavior is the same... Also with the 14 large games I tested this is the single time this happens.

Maybe we could still change the behavior so that the original else branch is put with comments and elif True is replaced with else to avoid confusion?

This problematic file (original and compiled):
group_event_dinner_time_2_dinner.zip

from unrpyc.