cemsbv / py-pilecore Goto Github PK

The plot_bearing_overview call raised a numpy error (complaining about Nan values) during the SingleCPTBearingResults.plot_bearing_overview() call. This is remarkable since these didn't show up in the unit-tests where None-value inputs are tested.

It turns out that the issue only occurs while using matplotlib < 3.8.

Solution is to require matplotlib >= 3.8

The soil_load property should not be passed as null. If soil_load_sls = None, we should pass 0 instead.

We'd like to show the name of the CPT In the plot_bearing_overview
In the figure below we can see that - clearly - we know the name of the CPT, but it still displays "unknown" in the image Legend.

Note: this is pilecore-python syntax, but the issue persist in py-pilecore

Some objects have a pandas.DataFrame representation, which is accessed as a pd property. These should be converted to a to_pandas() method (lru_cached)

Some from_api_response methods dump (partial) payload dictionary content as kwargs into dataclasses, e.g.:

CPTGroupResultsTable(**response_dict["group_results"])

This makes the workflow sensitive to non-breaking changes in the API: A new item in the response_dict dicitonary will break the workflow.

The Reference section in the docs should describe the SingleCPTBearingResults object

The MultiCPTBearingResults is quite a complex object with many sub-objects that needs a bit more explanation in the docs