ccs-amsterdam / amcat4react Goto Github PK

• if non-date fields are selected, reset interval
• if date field is selected, pick some sane interval default (or remember previous value?)
• allow only date (+number) for line charts?

It would be good to run through all components to see if state/values is always consistent when e.g. switching index or amcat

shows up every time you view a single article.

possibly caused here https://github.com/ccs-amsterdam/amcat4react/blob/master/src/lib/Article/prepareArticle.tsx#L62-L80 but not 100% sure

Edit: move is mostly complete, only upload is left, but that probably needs a bit of refactor first

I think we should move to type script.

This can be done by installing typescript and renaming sources files to tsx one by one. Imports also need to be changed AFAICS, it doesn't automatically check for a tsx file if you don't specify an extension (?)

Benefits:

• Better automatic documentation, especially of props
• Automatic checking especially of props and callback argument types -> fewer bugs
• Better autocomplete in editor

Process:

• https://webpack.js.org/guides/typescript/ install typescript and ts-loader and set webpack to run tsx files through ts-loader
• change jsx: react to jsx: react-jsx in tsconfig [https://stackoverflow.com/questions/64656055/react-refers-to-a-umd-global-but-the-current-file-is-a-module]
• deal with lots of error messsages

Useful links:

• https://www.typescriptlang.org/docs/handbook/2

I want to be able to point to an article and possibly to a query

Related (?), I want to have an host and index in the url to point people to the :right" location for a client

Selecting urls from a list doesn't make sense, but doing a substring/regex/elastic search as filter might.

This might actually work on all text fields, and/or we could think about a category for textual fields that are not really part of the document text, e.g. location, description, etc?

You can get this error by playing around with the index chooser. Might be a race condidition in setting the new index, but not entirely sure

• allow for range selections in filter
• use in aggregation

There should be zeroes e.g. between 2014 and 2019

To reproduce:

• choose an index, go to articles tab, open first article (no highlighting)
• query on a word in that article (e.g. Senate in sotu test index). Articles table is now highlighted.
• open the first article again, should be highlighted but isn't
• open any other article, and then re-open the first article. This will fix the highlighting

(similarly, changing/removing the query and then re-opening the same article will show the old highlighting)