Code Monkey home page Code Monkey logo

ccns-radio's People

Contributors

d4n1elchen avatar dependabot[bot] avatar gholk avatar hexrabbit avatar yuessiah avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

ccns-radio's Issues

重覆宣告參數等幾點 coding style 建議

不要宣告和參數同名的變數

function redeclareArgument(body) {
  var body = JSON.parse(body) // 重覆宣告了
  body = JSON.parse(body) // 可以直接覆寫是
  const json = JSON.parse(body) // 取一個新名字更好
}

不要在 block 裡宣告函數

記得 block 裡不能宣告函數,只能用函數表達式。
和不能在 block 裡用 var 宣告變數差不多。
雖然沒什麼關係,但我會盡量避免。

if (!err) {
  // 這樣不太 ok
  function recurElseListInside() {
  }
  recurElseListInside([])
}
// 宣告在外面比較好
function recurElseListOutside() {
}

為什麼要用 snake_case

javascript 統一用 camelCase 好嗎?
playList 裡怎麼一堆 song_list song_data

Preference saving

Add function to save preferences and song list.
Preference like kanban-musume's url and size and position, default volume, or some frontend costume setting.

Feel free to suggest any settings you want.

Song database

支援撥放列表資料庫
目前計畫支援 firebase 及本地端 json 資料庫

On-page search

Directly open a search window on page for adding new songs

port number 80

讓 web server 聽 port 80 ,
最好寫成設定檔。

Separate playlist and controller

It's better to separate playlist and controller. Currently, it's playlist that handle the player control command, but how the player is controlled actually isn't related to the playlist.

Controller will receive commands for either modifying playlist or controlling the frontend player, modify the playlist, and send command to dispatcher. Modules will only interact with controller.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.