ccns / ccns-radio Goto Github PK

Currently some shit keep printing out on the frontend console. Clean it up ASAP.

支援撥放列表資料庫
目前計畫支援 firebase 及本地端 json 資料庫

不要宣告和參數同名的變數

function redeclareArgument(body) {
  var body = JSON.parse(body) // 重覆宣告了
  body = JSON.parse(body) // 可以直接覆寫是
  const json = JSON.parse(body) // 取一個新名字更好
}

不要在 block 裡宣告函數

記得 block 裡不能宣告函數，只能用函數表達式。
和不能在 block 裡用 var 宣告變數差不多。
雖然沒什麼關係，但我會盡量避免。

if (!err) {
  // 這樣不太 ok
  function recurElseListInside() {
  }
  recurElseListInside([])
}
// 宣告在外面比較好
function recurElseListOutside() {
}

為什麼要用 snake_case ？

javascript 統一用 camelCase 好嗎？
在 playList 裡怎麼一堆 song_list song_data ？

submitting url again and again is very tired

讓 web server 聽 port 80 ，
最好寫成設定檔。

加清單的網址時，只要一首和已知的重覆，
就會終止，後面的歌都不會被加入。

應該不是人為的，大概

To check the success of command execution.

There are lots of global variable reference. It's better to avoid this kind of things.

It seems that there is no need to use websocket to implement song addition. Maybe have some discussion here.

It's better to separate playlist and controller. Currently, it's playlist that handle the player control command, but how the player is controlled actually isn't related to the playlist.

Controller will receive commands for either modifying playlist or controlling the frontend player, modify the playlist, and send command to dispatcher. Modules will only interact with controller.

For diagnosis and debugging

Directly open a search window on page for adding new songs

let volume up +3,
volume down -5.

so +1 = +3 +3 -5,
+2 = +1 +1,
can allow any volume value.

Client version of the player is broken in mobile browser.

Add function to save preferences and song list.
Preference like kanban-musume's url and size and position, default volume, or some frontend costume setting.

Feel free to suggest any settings you want.

(´･д･｀)ﾊ(･д･｀*)

(*ﾟ∀ﾟ*)

(the two sections above.)

README PLEASE

也就是該播的下首歌不播
直接跳到更後面的歌播