Code Monkey home page Code Monkey logo

Comments (10)

steven-moore avatar steven-moore commented on September 25, 2024

From my original e-mail: I have been testing Rachel Kelly’s file and have it mostly working. There is one minor issue though. She’s using non-R friendly names for metabolites. While this works by and large, it fails if you enter “individual metabolite names” or use the tag function.

So, for example, an analysis of age by diacetylspermine works just fine. But an analysis of age by C16 carnitine (with the space as part of the name) does not.

Most likely, we are using an array-based method when analyzing “all metabolites” (which mitigates the non-standard name issue), but not using this method when analyzing individual metabolites.

from r-cometsanalytics.

ellatemprosa avatar ellatemprosa commented on September 25, 2024

needs to investigate where it's failing whether in passing the web argument or in comets analytics

from r-cometsanalytics.

steven-moore avatar steven-moore commented on September 25, 2024

Scrambled.CPSII.data_comp_id_removed.xlsx

Ewy has changed the processing of metabolite names to make this an array-based system, but changes need to be made to the interface to fully capitalize on these changes. There are at least two examples:

  1. When making tags of metabolites, the metabolite names are not being properly mapped. Thus, when you examine metabolite*metabolite correlations using a tag, it results in mismapped metabolites and an error.

image

  1. When examining metabolite*metabolite correlations, names are dynamically updated for the outcomes (which is the intended functionality) but not for the exposures.

image

image

from r-cometsanalytics.

park-brian avatar park-brian commented on September 25, 2024

For item 2, the web application displays the outcome/exposure columns as-is from the correlation output. It looks like the outcome column's values have been mapped to the original metabolite names, but the exposure column does not have mapped metabolite names:

image

metab_data <- readCOMETSinput(system.file('extdata', 'cometsInputAge.xlsx', package = 'COMETS'))
model_data <- getModelData(metab_data, modelspec = 'Interactive', colvars = c('_1_2_3_benzenetriol_sulfate_2', '_1_2_dipalmitoylglycerol'), rowvars = c('_1_2_3_benzenetriol_sulfate_2', '_1_2_dipalmitoylglycerol'))
corr_data <- runCorr(model_data, metab_data)

View(corr_data)

from r-cometsanalytics.

steven-moore avatar steven-moore commented on September 25, 2024

That makes sense--so this needs to be taken care of on Ewy's end, correct?

from r-cometsanalytics.

park-brian avatar park-brian commented on September 25, 2024

Yes, once the package is updated the UI should pick up the new names.

from r-cometsanalytics.

steven-moore avatar steven-moore commented on September 25, 2024

See also issue #42

from r-cometsanalytics.

steven-moore avatar steven-moore commented on September 25, 2024

Per our phone conversation today, Ella will look into this and issue #42 (the two issues are interrelated)

from r-cometsanalytics.

steven-moore avatar steven-moore commented on September 25, 2024

The heatmap issue has been resolved (point 1 above), but the reporting for exposure and outcome metabolites still differ (point 2). I may be able to live with this, but we should at least discuss whether this is the functionality we want.

from r-cometsanalytics.

steven-moore avatar steven-moore commented on September 25, 2024

Fixed and closed

from r-cometsanalytics.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.