Comments (10)
From my original e-mail: I have been testing Rachel Kelly’s file and have it mostly working. There is one minor issue though. She’s using non-R friendly names for metabolites. While this works by and large, it fails if you enter “individual metabolite names” or use the tag function.
So, for example, an analysis of age by diacetylspermine works just fine. But an analysis of age by C16 carnitine (with the space as part of the name) does not.
Most likely, we are using an array-based method when analyzing “all metabolites” (which mitigates the non-standard name issue), but not using this method when analyzing individual metabolites.
from r-cometsanalytics.
needs to investigate where it's failing whether in passing the web argument or in comets analytics
from r-cometsanalytics.
Scrambled.CPSII.data_comp_id_removed.xlsx
Ewy has changed the processing of metabolite names to make this an array-based system, but changes need to be made to the interface to fully capitalize on these changes. There are at least two examples:
- When making tags of metabolites, the metabolite names are not being properly mapped. Thus, when you examine metabolite*metabolite correlations using a tag, it results in mismapped metabolites and an error.
- When examining metabolite*metabolite correlations, names are dynamically updated for the outcomes (which is the intended functionality) but not for the exposures.
from r-cometsanalytics.
For item 2, the web application displays the outcome/exposure columns as-is from the correlation output. It looks like the outcome column's values have been mapped to the original metabolite names, but the exposure column does not have mapped metabolite names:
metab_data <- readCOMETSinput(system.file('extdata', 'cometsInputAge.xlsx', package = 'COMETS'))
model_data <- getModelData(metab_data, modelspec = 'Interactive', colvars = c('_1_2_3_benzenetriol_sulfate_2', '_1_2_dipalmitoylglycerol'), rowvars = c('_1_2_3_benzenetriol_sulfate_2', '_1_2_dipalmitoylglycerol'))
corr_data <- runCorr(model_data, metab_data)
View(corr_data)
from r-cometsanalytics.
That makes sense--so this needs to be taken care of on Ewy's end, correct?
from r-cometsanalytics.
Yes, once the package is updated the UI should pick up the new names.
from r-cometsanalytics.
See also issue #42
from r-cometsanalytics.
Per our phone conversation today, Ella will look into this and issue #42 (the two issues are interrelated)
from r-cometsanalytics.
The heatmap issue has been resolved (point 1 above), but the reporting for exposure and outcome metabolites still differ (point 2). I may be able to live with this, but we should at least discuss whether this is the functionality we want.
from r-cometsanalytics.
Fixed and closed
from r-cometsanalytics.
Related Issues (20)
- Warning: bad alloc HOT 2
- COMETS 1.4. Correlations between metabolites with long names not currently working HOT 15
- COMETS 1.3. N not lining up (GUI display only) HOT 2
- COMETS 1.3. Amazon queue not managed correctly if 3+ jobs HOT 3
- COMETS 1.5. For metabolites that are dropped, indicate somehow that this happened HOT 2
- 1.5 Warning: "missing value where 'true/false' needed" HOT 1
- 1.4 hmdb_id + cohort options + subject data from BWHHS
- Error message for hmdb_id on Integrity Check HOT 1
- COMETS 1.4. Adjustment w/ BMI in sample file not working HOT 3
- COMETS 1.4. Integrity check fails when comp-id has characters HOT 2
- COMETS 1.4. Add "metabolites", "varmap", "models", table1 tabs to output harmonization file
- COMETS 1.5. Adjusting for metabolites in batch mode
- COMETS 1.5. Adjusting for a metabolite when "all metabolites" is an outcome HOT 3
- COMETS 1.4. In "DESCR" file produced when running "all models", metabolite array positions given instead of names HOT 4
- COMETS 1.4. When a metabolite is adjusted for, its array position is shown in adjvars instead of its name HOT 6
- COMETS 1.5. Fix warning messages to provide more useful feedback. HOT 1
- Error Message: Can't join on 'x__3' x 'x__3' because of incompatible types (character / numeric)
- COMETS 1.5. Clarify metabolite_id vs. metabid and which is required in the "Metabolites" tab
- Vignette error HOT 1
- subselect is no longer available on CRAN
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from r-cometsanalytics.