Code Monkey home page Code Monkey logo

Comments (8)

mbeckrich avatar mbeckrich commented on June 9, 2024 1

from obsidian.

mbeckrich avatar mbeckrich commented on June 9, 2024

Thanks! Getting the search result highlights nailed down has been tricky -- lots of sneaky CSS for them. Can you give me a little more context for the first screenshot? Is it from a plugin as well and are you using the full palette or one of the style settings specific ones? This is what my search results look like:

image

I will install the plugin in the second pic and get that fixed.

Edit: I have made some changes to the CSS for the plugin, so the poor contrast in your second pic shouldn't happen now (or at least not where I found it happening lol). Let me know if there are other spots I missed. As far as the search results, any additional context you can give (bigger screenshot, name of css element, etc.) would be helpful because I am not sure I recognize the part of the UI in your pic, sorry!

from obsidian.

ArtemisFowl-san avatar ArtemisFowl-san commented on June 9, 2024

Hey, thanks for the quick fix for the folder search results, they look perfect now πŸ‘

As for the first screenshot, it is the same anotherquickswitcher plug in and it is the same search bar, only that it already previews some of the search results for headers or keywords or inside the file

This image is the same, so the folder indicator on the right is perfect now as is the file name, only the in-file search results are still very hard to read.
image

I hope this helps. If I can do anything else to help just let me know.

from obsidian.

mbeckrich avatar mbeckrich commented on June 9, 2024

Cool, I think I may have been able to correct it using the grep search feature to test. This should reflect the native search results of the app now. Can you let me know if I am still missing any of the plugin's css? Thanks!
Screenshot 2023-01-13 at 2 13 33 PM

from obsidian.

ArtemisFowl-san avatar ArtemisFowl-san commented on June 9, 2024

Looks perfect now, thanks a lot !
image

I don't want to bother you too much with plug in compatbility, because I imagine it is an endless task, but would you mind also looking into the omnisearch plug in search results (see screenshot).

Feel free to skip this if it's too much just thought that I would ask :)

image

from obsidian.

mbeckrich avatar mbeckrich commented on June 9, 2024

Okie doke, let me know how that looks now. Don't feel bad about asking for plugin additions -- happy to do it when I have time. You're also welcome to submit PRs for review if you're famliar with CSS (or want to learn!) and want to contribute. :)

from obsidian.

ArtemisFowl-san avatar ArtemisFowl-san commented on June 9, 2024

thanks, and yes once I am done with exams for this semester I was thinking about diving a bit deepter into CSS, so will definitely come back to this then :)

from obsidian.

mbeckrich avatar mbeckrich commented on June 9, 2024

Great! I updated the readme a couple days ago with some additional info about contributing and there's a footnote that gives an example of how to build the app scss with sass if you haven't used it before. I'll close this for now but let me know if there's anything else I can do to help. Good luck with exams!

from obsidian.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.