Code Monkey home page Code Monkey logo

Comments (5)

nullishamy avatar nullishamy commented on June 2, 2024

Hiya

Overall, looks good! Only a few things to amend:

  1. Your repo has .yaml files that actually contain TOML.
  2. The installation guide is not terribly clear. It should make it more clear that you have to manually merge the theme into your config, rather than simply placing the file in the specified location.
  3. These configs are not generated with a script. If possible, we'd prefer this, though it is not a deal breaker.

from catppuccin.

iruzo avatar iruzo commented on June 2, 2024

Hi !

  1. Oops, true, done!
  2. Ty for noticing, done!
  3. I created this port really fast since it is one of those simple apps with really simple configs. If it is really necessary I can take the time to change it.

from catppuccin.

sgoudham avatar sgoudham commented on June 2, 2024

I think its fine to revisit the repository for generating with whiskers, once that's more defined.

Just two things from me:

  1. I'd add a note into the Usage saying that the default theme provided by application is already Catppuccin Mocha, so they don't need to copy it over.
  2. Regenerate the previews with a much bigger font size since 80% of the current preview is the terminal and not the application itself.

Should be good to transfer after the above changes have been carried out!

from catppuccin.

iruzo avatar iruzo commented on June 2, 2024

@sgoudham

  1. Done
  2. Done

Thanks for the feedback !

from catppuccin.

sgoudham avatar sgoudham commented on June 2, 2024

Thanks, I'm happy for it to be transferred over to the organisation!

Please read, "Transferring a repository owned by your personal account", if you are unsure about the process of transferring the repository to Catppuccin.

We'll close this issue once the port has been added to our ports.yml.

from catppuccin.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.