Code Monkey home page Code Monkey logo

Comments (5)

uncenter avatar uncenter commented on June 10, 2024 1

I wonder if it is worth theming the icons as well? Obviously not a priority but it would be neat. Looks like they are SVGs so hopefully not too difficult!

Here is the docs on it: https://manual.calibre-ebook.com/customize.html#creating-your-own-icon-theme-for-calibre.
Folder containing default icons: https://github.com/kovidgoyal/calibre/tree/master/imgsrc.

from catppuccin.

sgoudham avatar sgoudham commented on June 10, 2024 1

Hey 👋
Thanks for your work!

I've got a few comments:

  1. I think it would be good to add the icons/dist folder to a .gitignore file as the icons are generated by a makefile and not needed in source control.
  2. I feel like it'd be nicer to rename the theme files as catppuccin-<flavour>-<accent>.calibre-palette instead of just <accent>.calibre-palette. I know I'd much prefer downloading the former into my filesystem (and also prevents rename popups if you're downloading multiple accents/flavours)
  3. The Base key should be set to base instead of mantle as I assume that this is the main background. For further details on how base/mantle should be used in accordance with our other ports, see my comments on the Gitkraken issue (i.e main background as base and sidebars/sidepanels as mantle)

from catppuccin.

42Willow avatar 42Willow commented on June 10, 2024

Ok, I'll give this a go. Do you know of any efficient method of doing this in batch either automatically or manually with inkscape? If not that's fine, I've got a lot of clicking to do.

Do you think it would better to retain the gradients in the icons or get rid of them?

from catppuccin.

uncenter avatar uncenter commented on June 10, 2024

Ok, I'll give this a go. Do you know of any efficient method of doing this in batch either automatically or manually with inkscape? If not that's fine, I've got a lot of clicking to do.

Hmm I mean I have a tool called ctpvert that attempts to find the closest Catppuccin color but for best results I would do it manually.

Do you think it would better to retain the gradients in the icons or get rid of them?

I'm in favor of getting rid of the gradients :)

from catppuccin.

sgoudham avatar sgoudham commented on June 10, 2024

Discussed on discord with @42Willow, port looks good and thanks for implementing my above suggestions!

I'm happy for it to be transferred over to the organisation! Check your inbox for an invite to the Catppuccin GitHub organisation.

Please read, "Transferring a repository owned by your personal account", if you are unsure about the process of transferring the repository to Catppuccin.

We'll close this issue once the port has been added to our ports.yml.

from catppuccin.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.