catalyst / moodle-mod_facetoface Goto Github PK

We are hosting several Moodle sites, two have the Face-to-Face plugin installed and in use, the others have it installed, but not currently in use. On the two sites with the plugin assigned to courses and students registered, the CRON job can not complete due to an error reported in the CRON job:
Processing cron function for local_reminders...
... started 06:40:32. Current memory use 6.7MB.
[Local Reminder] Time window: Sunday, 21 April 2019, 7:29 AM to Wednesday, 24 April 2019, 6:40 AM
[Local Reminder] Found 12 upcoming events. Continuing...
[Local Reminder] Sending all reminders as Admin User...
[Local Reminder] Processing event#2042 [Type: facetofacesession, inaheadof=1 days]...
[Local Reminder] Couldn't find option for event 2042 [type: facetofacesession]
[Local Reminder] Processing event#2049 [Type: facetofacesession, inaheadof=1 days]...
[Local Reminder] No reminder is due in ahead of 1 for eventtype facetofacesession [event#2049 is ignored!]...
[Local Reminder] Processing event#2056 [Type: facetofacesession, inaheadof=1 days]...
[Local Reminder] Couldn't find option for event 2056 [type: facetofacesession]
[Local Reminder] Processing event#2057 [Type: facetofacebooking, inaheadof=1 days]...
[Local Reminder] Couldn't find option for event 2057 [type: facetofacebooking]
[Local Reminder] Processing event#2058 [Type: facetofacebooking, inaheadof=1 days]...
[Local Reminder] Couldn't find option for event 2058 [type: facetofacebooking]
[Local Reminder] Processing event#2059 [Type: facetofacebooking, inaheadof=1 days]...
[Local Reminder] Couldn't find option for event 2059 [type: facetofacebooking]
[Local Reminder] Processing event#2060 [Type: facetofacebooking, inaheadof=1 days]...
[Local Reminder] Couldn't find option for event 2060 [type: facetofacebooking]
[Local Reminder] Processing event#2061 [Type: facetofacesession, inaheadof=1 days]...
[Local Reminder] No reminder is due in ahead of 1 for eventtype facetofacesession [event#2061 is ignored!]...
[Local Reminder] Processing event#1206 [Type: facetofacesession, inaheadof=3 days]...
[Local Reminder] Couldn't find option for event 1206 [type: facetofacesession]
[Local Reminder] Processing event#1207 [Type: facetofacesession, inaheadof=3 days]...
[Local Reminder] Finding out users for event#1207...
[Local Reminders] host [ REMOVED - Edited by me ]
[Local Reminder] Starting sending reminders for 1207 [type: facetofacesession]
!!! Exception - Argument 1 passed to message_send() must be an instance of core\message\message, instance of stdClass given, called in [dirroot]\local\reminders\lib.php on line 432 !!!

Not sure how to resolve.

Thank you

It is currently possible to export a list of users for all sessions from the view all sessions page. However, when you have a LOT of these sessions, or when a teacher simply wants to have a print out of users along with their contact information, who are enrolled in a particular session. For example, Taking in-person attendance offline and entering the information later), importing attendance records into another application, etc.. It would therefore be really useful to have the ability export users from a single session.

I would therefore like to propose and request that one of the following two options:

• Add an icon for Excel and ODS to download list of attendees for each of the listed sessions in the View All Sessions page; or
• Add to the "Attendees" page to export the list of attendees for that single session. This would be added to the existing options which include "Take Attendance, Add/Remove Attendees and Go Back.

Best regards,

Michael Milette

This CSS found in styles.css is no longer necessary, even before it was incorrect because the selectors were too general and could affect other plugins.

table.table90 {
    width: 90%;
}
table.table50 {
    width: 50%;
    text-align: left;
}
table.inlinetable {
    display: inline-table;
    border: 0;
}

Previously used tables were replaced with divs and spans, which means we can safely remove this obsolete CSS.

Second related problem is use of 'highlight' class in session list. It was introduced at the same time. Solution is to add a class to the session list table and apply the highlight only there.

tr.highlight td.cell {
    font-size: 12px;
    line-height: 18px;
}

Third problem is too general error class

span.errorstring {
    font-size: 12px;
    line-height: 18px;
}

$plugin->version = 2020080400;
$plugin->requires = 2017111300; // Requires 3.4.
$plugin->release = '3.9.1';
$plugin->component = 'mod_facetoface';
$plugin->maturity = MATURITY_STABLE;

Should be:
$plugin->requires = 2021051700; // Requires 3.11.

Hey,

I've been checking out the new version.
When I set a cost and discount cost I notice you MUST set a discount code field when signing up for the event, shouldn't this be an optional field? Not everyone will have a discount code.

Thanks!
Sky

Updated to

Face-to-Face
mod_facetoface
3.4.1
2018062000

using Moodle Moodle 3.4.2+ (Build: 20180512).

Export to Excel the sessions is producing spreadsheet that has hundreds of columns and is not usable to see who is booked on to which session. Was fine in previous verson.

If you create a course with F2F activities/sessions, and import the content from that course into a new course, new modules/sessions/calendar events are created but the event in the new course has a link that still points to the original session in the original course.

Tested on: Moodle 3.11.11, Face-to-Face 2021113005

Steps to recreate issue

• Create a new course F2F1, with a F2F module and add a session with defaults on calendar options settings - calendar display settings = course
• Observe there is a calendar invite for the session that includes the correct session date/time info, link to correct course, and sign up for session link that links to the session eg http://moodle/mod/facetoface/signup.php?s=1
• Create a second course F2F2. Import the content from F2F1
• Observe there is a calendar invite on the F2F2 calendar for the session that includes the correct session date/time info, link to correct course, and sign up for session link that links to the original session in F2F1 course eg http://moodle/mod/facetoface/signup.php?s=1
• observe that the correct session here would be http://moodle/mod/facetoface/signup.php?s=2

After latest changes there is an issue with session dates when exporting to excel :

( ! ) Notice: A non well formed numeric value encountered in /var/www/xxx/lib/moodlelib.php on line 2275

1 | 0.0003 | 361336 | {main}( ) | .../view.php:0
2 | 0.0383 | 6013168 | facetoface_download_attendance( ) | .../view.php:80
3 | 0.0519 | 7162496 | facetoface_write_activity_attendance( ) | .../lib.php:1294
4 | 0.0618 | 7350560 | facetoface_write_activity_attendance_helper( ) | .../lib.php:1560
5 | 0.0642 | 7361520 | MoodleExcelWorksheet->write_date( ) | .../lib.php:1632
6 | 0.0642 | 7361520 | usergetdate( ) | .../excellib.class.php:230
7 | 0.0642 | 7361520 | getdate ( )

Will submit fix soon

When signing up per session, a screen with the session details is displayed.

With signups that are "Per activity" it's not possible to see the individual session details (which may contain some important information).

Moodle 3.10.6
mssql 11.00.7493
php 7.2.26
mod-facetoface 3.9.1 (2020080400)

If manager approval is turned on in F2F then the manager email in the user (student/employee) profile (shortname managersemail) is correctly displayed for confirmation.
The manager email field can be updated by the user but it looks as if the value is ignored and the manager confirmation email goes to the (incorrect) original value in the user profile regardless. The manager value in the user profile is often wrong or may be away etc so allowing the user to nominate an alternate address is required (even if only for this request and doesn't update the profile) .

Code screenshot provided by our hosting company indicates the capability for the user to update the address may have been removed by Stacy Walker? (although the user still has the ability to enter an alternate value)

Can you please confirm the current function of the manager approval dialogue for whether the user should be able to update the field and the save and email send functions

thanks, Phil

In some cases Options column is empty and there is no point to show it.

Temporary file is created directly under $CFG->dataroot:
https://github.com/catalyst/moodle-mod_facetoface/blob/master/lib.php#L2859

It would be better to create it under $CFG->dataroot / temp directory.

looks like we missed merging some of the commits from the 2.9 dev branch onto master - particularly around rendering refactoring but I'm guessing some of it may conflict with 1769e27

Hello,

Currently the F2F notifications coming out of the plugin are plain text, however we would like to customize this to include media such as images and colors. An idea is by incorporating the Moodle Atto editor that allows rich text to be created.

We're planning to begin by modifying the plaintext field in the session confirmation email section to instead used the Moodle Atto editor. Following which we plan to modify any of its other dependencies to accept the rich text and send out better looking emails.

This is an issue we can attempt to work on with a guidance and review from your team. 😄

Updated plugin to latest version (2.8) on commit hash ca5004b
Running 2.8.5

Get a fatal error when going to events list
Coding error detected, it must be fixed by a programmer: Invalid event class name 'mod_facetoface\event\signup', there must be at least one underscore separating object and action words

Getting Fatal error: Cannot redeclare format_duration() (previously declared in /var/www/qut-mwp/mod/appointment/lib.php:136) in /var/www/qut-mwp/mod/facetoface/lib.php on line 201

And MDL_MANAGERSEMAIL_FIELD already defined

The plugin will not allow the use of our valid domain '@rhapsody.health'.

In the current release of Face-to-face (tested in Moodle 3.3 and 3.4) when configuring an instance you have the choice to set the Calendar display settings to Site, Course, or None. In earlier versions of Face-to-face Site added it as a global event and course as course event and none didn't add it to the calendar at all.

In the current version both Site and Course options appear to add it a course event, so you can't add a face-to-face session to the calendar as a global event at all. This requires users to be enrolled in the course to ever see the session.

In earlier versions you could use Face-to-face as a way to advertise courses via the calendar and drive enrollments.

Hi,

This line in code is currently confusing our team. On adding people to a face-to-face session we also want them to be added as participants on the course. However, this check skips over the latter part when the user has permission to view a course (eg: user is a Manager).

Initially we considered it was a bug, but upon further checking it seems this is intentional ("Users with this capability are NOT listed as course participants").

Can you help advise us whether we can safely remove this line? What happens if a user with elevated permissions (ie, Manager) is added as a participant, and what's the reasoning behind the idea that they are not supposed to be participants? If it helps, upon removing this line people are added as participants irrespective of their roles.

Thanks!
Vedant

Adding a new session using FaceToFace on 3.11 throws the following errors:

get_all_user_name_fields() is deprecated. Please use the \core_user\fields API instead
line 3384 of /lib/deprecatedlib.php: call to debugging()
line 3722 of /mod/facetoface/lib.php: call to get_all_user_name_fields()
line 159 of /mod/facetoface/classes/session_form.php: call to facetoface_get_trainers()
line 214 of /lib/formslib.php: call to mod_facetoface_session_form->definition()
line 143 of /mod/facetoface/sessions.php: call to moodleform->__construct()

get_all_user_name_fields() is deprecated. Please use the \core_user\fields API instead
line 3384 of /lib/deprecatedlib.php: call to debugging()
line 167 of /mod/facetoface/classes/session_form.php: call to get_all_user_name_fields()
line 214 of /lib/formslib.php: call to mod_facetoface_session_form->definition()
line 143 of /mod/facetoface/sessions.php: call to moodleform->__construct()

See https://tracker.moodle.org/browse/MDL-45242 for deprecation notice:

The corresponding existing functions are all deprecated: get_extra_user_fields(), get_extra_user_fields_sql(), get_user_field_name(), get_all_user_name_fields(), and user_picture::fields(). All the features from these functions are subsumed into the new API:

https://docs.moodle.org/dev/User_fields

Best regards,

Michael

Hello there,

Here at Liip, we have a client who is not too pleased that their users are receiving two separate emails when signing up with Email notification and iCalendar Appointment. After a bit a research, we fell on this forum answer, which explains that MS Outlook behaviour forced your hand to send two emails.

We were thinking of adding an option to disable that second email if MS Outlook isn't used. But before we start anything, we were wondering if this is something you already plan on implementing. If not, would be something that would be accepted for merge in your main branch.

Cheers,

Doran

If I include an ampersand (&) in the title of a f2f activity, the "My Courses" block displays the ampersand as & rather than an '&'.
Images below:

Since PHP 7.3 a warning is raised (about an existing problem) when continue; commands are used within switch statements. Really they act as break; statements instead, and one should be using continue 2; to achieve continue functionality. There is a ticket here tracking Moodle core effort to round up and exterminate these instances: https://tracker.moodle.org/browse/MDL-63422

These warnings are present in the log file when viewing pages and courses that do not contain mod_facetoface activities - e.g. admin and plugin management pages - and clutter up the logs when doing development.

Log messages when tested on Moodle 3.7.1, mod_facetoface 3.4.3 (latest), and PHP 7.3:

[Mon Mar 23 13:29:02.300560 2020] [php7:warn] [pid 11140] [client [[ip]]:62036] PHP Warning:
"continue" targeting switch is equivalent to "break".
Did you mean to use "continue 2"? in /var/www/html/moodle/mod/facetoface/lib.php on line 2426, referer:
https://url/admin/index.php?cache=1
[Mon Mar 23 13:29:02.300701 2020] [php7:warn] [pid 11140] [client 1[[ip]]:62036] PHP Warning:
"continue" targeting switch is equivalent to "break".
Did you mean to use "continue 2"? in /var/www/html/moodle/mod/facetoface/lib.php on line 2434, referer:
https://url/admin/index.php?cache=1
[Mon Mar 23 13:29:02.301364 2020] [php7:warn] [pid 11140] [client [[ip]]:62036] PHP Warning:
"continue" targeting switch is equivalent to "break".
Did you mean to use "continue 2"? in /var/www/html/moodle/mod/facetoface/lib.php on line 3851, referer:
https://url/admin/index.php?cache=1

When a teacher tries to add/remove attendees manually, instead of searching enrolled students only, the system searches through all users in the database.
We've ran into an issue where we have a large number of users (150k+) and many share the same name, teachers are adding unrelated users into sessions. Consequently the users are also enrolled into the course.

Introduced in 37011d3

A superfluous parameter was added to facetoface_send_notice in lib.php. $htmlmessage parameter is always overwritten.

All implementations of facetoface_send_notice did not implement the new required parameter.

The parameter $htmlmessage should be removed.

Exception - Too few arguments to function facetoface_send_notice(), 7 passed in [dirroot]/mod/facetoface/lib.php on line 2196 and exactly 8 expected

Hi @danmarsden
Seems you forgot to update plugin DB when you released 3.9 compatible version :)
Current latest release on plugin DB is 3.4.3 (2018110900) for Moodle 3.5.

TIA

Hi,

Is there a particular reason to limit event name to 15 characters ? It is really short.

AFAIK technically mdl_event.name is a longtext and module name which is used to build the event name is a varchar(255).
I know that you can use "shortname" if you want to display a specific (and length unlimited) event name but it forces teachers to do double entry if they only want the module name to be displayed completely.

IMO truncate should be done on display only (and is correctly handle by the calendar) and not during event creation.

Hello,

There is a bug in Face-2-Face 3.9.1 (2020080400) for example message

This is to advise that your booking on the following course has been cancelled: ***BOOKING CANCELLED*** Participant: [firstname] [lastname] Course: [facetofacename] Duration: [duration] Date(s): [alldates] Location: [session:location] Venue: [session:venue] Room: [session:room]

If you leave Location, Venue and Room fields empty then in the email message sent they are displayed as:

• Location: [session:location]
• Venue: [session:venue]
• Room: [session:room]

When it should say

• Location:
• Venue:
• Room:

No need to print variable names.

In Moodle 3.8.1 custom session fields that are used by notifications not available after plugin installation.
Helped myself to add the custom fields (location, venue, room) through the facetoface settings page. Funny the help texts are available on the sessions page once you add the custom fields. Furthermore, the custom fields also get displayed on the session overview page. Thus the system knows what to do with these items once they exist ;-)

I posted this in the Moodle Face-to-Face forum, but maybe this is a better place to post the errors I am seeing.

I am using Moodle 2.8.3+ (Build: 20150225) and the Face to Face mod version 2015021300.

When signing up for a session I get to the signup screen click "Signup" and am then presented with the message "Coding error detected, it must be fixed by a programmer: Invalid event class name 'mod_facetoface\event\signup', there must be at least one underscore separating object and action words". The signup appears to go through successfully and the errors appear to be centered around the new events system Moodle uses.

When I cancel the booked session I get the message "Coding error detected, it must be fixed by a programmer: context (or contextid) is a required event property, system context may be hardcoded in init() method". Again the cancellation appears to be successful with the errors surrounding the event system.

Here is what I am getting in my php error log.

[12-Mar-2015 08:52:41 America/Denver] PHP Notice: Undefined variable: contextmodule in C:\WWWdev\WWW\mod\facetoface\signup.php on line 136
[12-Mar-2015 08:52:41 America/Denver] Default exception handler: Coding error detected, it must be fixed by a programmer: Invalid event class name 'mod_facetoface\event\signup', there must be at least one underscore separating
object and action words Debug:
Error code: codingerror

• line 132 of \lib\classes\event\base.php: coding_exception thrown
• line 159 of \lib\classes\event\base.php: call to core\event\base->__construct()
• line 139 of \mod\facetoface\signup.php: call to core\event\base::create()

[12-Mar-2015 08:53:30 America/Denver] PHP Notice: Undefined variable: contextmodule in C:\WWWdev\WWW\mod\facetoface\cancelsignup.php on line 78
[12-Mar-2015 08:53:30 America/Denver] Default exception handler: Coding error detected, it must be fixed by a programmer: context (or contextid) is a required event property, system context may be hardcoded in init() method. Debug:
Error code: codingerror

• line 204 of \lib\classes\event\base.php: coding_exception thrown
• line 81 of \mod\facetoface\cancelsignup.php: call to core\event\base::create()

Hope this is helpful. Please let me know if I can help debug or test fixes for this. Thanks.

Scott

When did session_form.php get removed? Did it get replaced by something else? I am working with an old version that was partially updated to $plugin->version = 2019011601; // 3.6.1 update AND added table to enable user interest feature

We have done a lot of customizations so the update was a little bit of a mashup be tween versions.

I am just wondering where the form validation function is that used to be in session_form.php. ??

While testing face-to-face we have added Custom Session Fields. They are Location, Venue and Room. The check box to show in exports and list is selected however when we export while the columns are created the values are blank.
Is this expected behaviour?

Hi Dan, I would like to ask if you would be interested in a new feature that adds F2F attendance status to completion criteria? Here is the original description, I am asking before I start cleaning up our current patch for upstreaming:

For completion tracking, the Face-to-face module currently only supports the options:

• Do not indicate activity completion
• Students can manually mark the activity as completed
• Show activity as complete when conditions are met

If you select "Show activity as complete when conditions are met" your options are:

• Student must view this activity to complete it
• Student must receive a grade to complete this activity

Face to Face allows the following options "No show", "Partially Attended", or Fully Attended" when taking attendance. The "Partially Attended" and "Fully Attended" options should be added to the options for "Show activity as complete when conditions are met" to be met.

• Student must be marked "Partially Attended"
• Student must be marked "Fully Attended"

F2F icon will not display when browsing 'Manage Activities' and 'Plugins Overview' on Safari Browser. This is ONLY on Safari (Latest), if I delete two icons from mod/facetoface/pix and leave only the .png or .gif the icon will render.

When signup type is set to "Multiple" and multiple signup method is set to "Per activity", when a student registers, they are registered for every session in the activity.

When a teacher adds a student via the "Upcoming sessions" screen, they can only add them per session. When signup type is set to "Multiple" and multiple signup method is set to "Per activity" it would make sense to allow the teacher to register the student for every session.

Hi!

We're trying to use Face-to-Face to allow teachers to book courses for their classes at an open event of our university (which happens every two years). We used the plugin the last few times and were quite happy with it. So were quite thrilled to see an update coming around the corner just in time. But unfortunately we can't get it to work and hope you can help us.

Every time we add the activity, the form shows up, we can fill it, but after we hit submit, we only get a blank page. Upon returning, no new activity has been added.

Digging a bit in, all facetoface tables remain completely empty and the error log says:

Potential coding error - active database transaction detected during request shutdown:\n* line 105 of /course/modlib.php: call to moodle_database->start_delegated_transaction()\n* line 266 of /course/modedit.php: call to add_moduleinfo()\n, referer:http://moodle.my/course/modedit.php?add=facetoface&type=&course=3&section=2&return=0&sr=0

Our system is:

• mod_facetoface 2.8.0 (Build: 2015021300)
• Moodle 2.8.3+ (Build: 20150205)
• MySQL 5.5.41
• PHP 5.4.36-0+deb7u3
• Apache 2.2.22 (Debian)

We'd appreciate any hints on what we might have to change (or of course a patch).

Thanks in advance.

Oliver

We are getting slow times when we add or sign up for facetoface session in the latest version 3.2.1

It does work fine on exiting face to face course prior upgrading to 3.2.1, however, any new courses, we get slow responses on adding or remove students from sessions.

Any thoughts?

Hello

I see that you have a patch to integrate with the certificate module, is there a chance or a hint on how to incorporate with Simple Certificates

TIA
John

I have tried the forums with no luck.
Users are not able to singup to sessions and a message comes up there is no manager assigned.
I have carried out everthing the forums say to do, creating the managersemail and still no go.

I found in the early stages you had to fill 'MSN ID' so I did that and it worked, but I want to be able to lock and hide the email in the suggested way above.

has this been removed ??

Hi ,

When student was supposed to attend previous session but he/she did not attend (Marked as no show), and this student registers for future session, there will be 0.00 as attendance in the attendance report for future session. Do you think this is a bug, or the attendance field in attendance report should be per face-to-face activity not per session?

Should we compare the dategraded with the session created time inside this if statement?

Thanks

John Y

When running basic operational tests on mod_facetoface version 2020080400 release 3.9.1 on latest Moodle 3.11 with PHP 7.4, the following error is encountered which seems to be related to recent changes in the latest PHP 7.4:

Warning: "continue" targeting switch is equivalent to "break". Did you mean to use "continue 2"? in .../mod/facetoface/lib.php on line 2426

I am planning on adding a feature to optionally disable the sending out of emails to students. I noticed that the version of lib.php here on GitHub (master branch) is different than the version I downloaded from Moodle.org.

The version.php files between the two versions are identical so I am not sure which is newer.

Could you please tell me which of the two has the more recent version of lib.php? I suspect that it is the one on GitHub but just want to be sure before I begin working on it.

In issue #65 we got the ability to export a list of attendees from single session. It would be useful to be able to import this same list into another session, for example to move attendees between sessions or import from some external system.

I propose one of the following two options:

• Add an icon for Excel/CSV import of attendees for each of the listed sessions in the View All Sessions page; or
• Add to the "Attendees" page to import an Excel/CSV list of attendees for that single session. This would be added to the existing options which include Take Attendance, Add/Remove Attendees and Go Back.

I recognize this is unlikely to happen without funding, but thought it'd be good to have an open request.

Using the current repo version of 2018070500 with Moodle 3.4.

It looks like the new facetoface_write_activity_attendance_helper function needs to have $sessiondate added as a parameter as line 1599 will always be empty: https://github.com/catalyst/moodle-mod_facetoface/blob/master/lib.php#L1599

Thanks!
Jesse

Here is a screen shot of the message I got

Add a new status "Cancelled" which leaves sessions still displaying in the list; but prevents any signups.

The cancellation feature is very useful; however, a learner can cancel his/her session enrolment at any time in the lead-up to a scheduled classroom session. Needless to say, a trainer may be left with a half-empty room at the last minute. It would desirable to control this situation by preventing said cancellations x days/hours/minutes before a scheduled session is due to start. Please advise if Catalyst are now only enhancing this plugin on a 'user-pays' basis.

If a teacher or trainer adds a user to a F2F session without first enrolling the user F2F adds the user to the course using the manual enrollment method. However, it doesn't apply a user role.

Without a role the user isn't able to see most course content - including the F2F instance. Manual enrollments include a default user role setting. It would seem reasonable to apply that role automatically.