cashubtc / enuts Goto Github PK

Requires editing Manifest in Expo managed repos to allow url-schemes like "lightning:".

https://stackoverflow.com/questions/64699801/linking-canopenurl-returning-false-when-targeting-android-30-sdk-on-react-native

http://getsentry.com/

https://docs.expo.dev/guides/using-sentry/

iPhone 11 Pro IOS 16.5

Adding a new mint does not show the success modal. It only shows the dark background.

Description:

The design is currently not responsive and has only been tested on 2 android smartphones.

Requirement:

Adapt the layout of all pages for tablets.

Note:

It is very likely that the layout of some pages/components is broken as well on small smartphones like iPhone SE.

Description:

As a user,
I might want to secure my app access with an authentication method or just skip the process
So that I can avoid foreign access to my funds

Note:

Using react-native key-value secure store for PIN storage should be sufficient to achieve this.
https://github.com/cashubtc/eNuts/blob/main/src/storage/store/SecureStore.ts

Requirements:

• PIN setup/skip on initial start
• PIN confirm after setup on initial start
• PIN query (if setup by user previously) on initial start
• Lock screen after 3 failing attemps. Time locked should raise on each failing attempt. (2m, 5m, 10m)
• Edit/remove/setup PIN in settings/security
• Ask for PIN if app comes to the foreground after beeing > 5 mins in the background.
• Translate the screen

Enhancement/Ideas:

1. Auth method selection on initial start (PIN, TouchID, FaceID)
2. Activate/deactive Auth query for a LN TX in settings.

https://docs.expo.dev/versions/latest/sdk/local-authentication/

API requests are currently throwing an error on iOS only. I was not able to trace the error or get more detailed information. Unfortunatly the expo-go debugger is currently not working on windows: expo/expo#23332. I am not sure at all why this axios error is happening and it would be good if we can have some collective debugging for this.

You can reproduce the error by adding the test mint: press mints -> test-mint -> confirm

@andrew-weber

Implement a request timeout where the duration can be customized by the user in the settings.

• for lightning payments
• for mint communication

Is your feature request related to a problem? Please describe.
I can only send Ecash to my nostr follow list

Describe the solution you'd like
I would like to send to a specific npub

Absence of type safety for translation keys.

Consequently, if a translation resource is missing or underwent a name change, the TypeScript compiler will fail to detect it, resulting in potential errors during runtime.

Create type declaration for i18next in /typings

See solution:

• https://locize.com/blog/i18next-typescript/
• https://www.i18next.com/overview/typescript

Show custom mint name on all components that show the mint URL

Once the numeric keyboard is open, there is currently no possibility to dismiss it or to tap the action buttons

• Add a contributing.md with workflow description
• Provide development docs and npm script usage
• Provide a list of implemented NUTs
• Link to the cashu-ts lib
• Link to the latest release page

• Provide an option to check if the token is spendable

• Provide an option to Show the QR code of the token

The scanned callback is not firing

Description
Remove the hard-coded 'en' locale in the Format functions and use the device locale

Provide a better overview over the keyset ids in a proof-list.

The latest keyset ids could be Highlighted in Green and the older one in yellow

• Show total amount of pending tokens for all user mints in dashboard

Describe the bug
When a user performs a Lightning transaction (melt or swap) and got not charged any fee (based on his balance afterwards), the key "realFee" still returns the same amount as the "estimated fees" that is determined before a Lightning transaction.

To Reproduce
Steps to reproduce the behavior:
0. Remember your balance before starting to reproduce.

1. Go to 'dashboard' and press 'Send'.
2. In the bottom popup, press on 'Pay Lightning invoice'.
3. Optionally (multiple mints with balance available), choose a mint URL to perform melt/swap transaction from.
4. Select any recipient option that fits best to you. (Does not matter, each one will reproduce the bug)
5. Go through the steps provided by the UI until the invoice is paid by the mint.
6. If payment is successfull, a "success screen" will be shown where a FEE amount is displayed (realFee).
7. Fee is higher than 0 even if no fees have been payed.

Expected behavior
"realFee" should be the exact amount of fees that have been payed for a Lightning transaction. If payed 0 fee, then realFee has to be 0.

Additional context

• Branch: UX
• The code that is used to show the "realFee" in the success screen can be found here
• The function that is used for melting is here and the code used in that function that calculates the realFee is here

• Check which theme is configured in the users device to provide it at inital start.
• Add an option "auto" into the theme settings and change the toggle to a dropdown.

https://blog.expo.dev/expo-sdk-49-c6d398cdf740

Problem

In our current repository, maintaining consistent code formatting can be a challenge. Developers have their own preferences and coding styles, leading to inconsistent formatting across the codebase. This not only hampers code readability but also increases the potential for merge conflicts and decreases overall productivity.

Solution

I propose that we integrate Prettier into our repository to automate and enforce a consistent code formatting style. Prettier is a widely adopted code formatter that supports multiple programming languages. It analyzes the code and automatically applies a predefined set of formatting rules, ensuring a consistent style across the entire codebase.

Benefits

1. Consistent Code Formatting: Prettier will automatically format the code, eliminating any inconsistencies caused by individual preferences. This will result in improved code readability and maintainability.
2. Time Savings: Developers will no longer need to manually format their code or spend time debating formatting choices. Prettier will handle the formatting automatically, allowing developers to focus on writing code and delivering features.
3. Reduced Merge Conflicts: Inconsistent code formatting often leads to unnecessary merge conflicts during code reviews and collaboration. By enforcing a consistent style with Prettier, we can minimize the occurrence of these conflicts and streamline the review process.
4. Ease of Onboarding: With Prettier in place, new team members can quickly adopt the project's formatting conventions without having to spend time learning and adjusting to individual coding styles.

Implementation

To add Prettier to our repository, we can follow these steps:

1. Dependency Installation: Add Prettier as a development dependency to our project's package.json or similar dependency management file.
2. Configuration: Create a configuration file (e.g., .prettierrc) in the project root directory to define our preferred code formatting rules. This file can be shared and version-controlled within the repository.
3. Integrate with Build Pipeline: Incorporate Prettier into our build pipeline or pre-commit hooks to automatically format the code before commits or during the build process.
4. Editor Integration: Encourage developers to install editor plugins or extensions that support Prettier to enable on-the-fly code formatting during development.

Considerations

Before implementing Prettier, we should consider the following factors:

• Check if any existing code formatting guidelines or conventions are in place and ensure that they align with Prettier's defaults or configure Prettier accordingly.
• Review any potential impact on existing linting rules and consider how Prettier can be integrated alongside the existing linters.
• Communicate the change to the development team, provide documentation or guidelines on how to use Prettier, and address any concerns or questions they may have.

By implementing Prettier, we can establish a standardized code formatting process, enhance collaboration, and improve overall code quality. I believe this addition will significantly benefit our development workflow.

https://pnpm.io/pnpm-vs-npm

Description:

As a user,
I want to run the app in my preffered language
So that I can use it if I do not understand english very well

https://docs.expo.dev/versions/latest/sdk/localization/
https://itnext.io/how-to-use-i18next-in-react-native-expo-476fa80bd92c

This seems to happen since the following PR: #106

• Add memo text input in token send page
• Validate memo string
• Use submitted memo to create token
• Show memo after claiming token

Will provide a new release with a Fix today

• README
• Github issues
• R&D telegram groups

Add linking: '**cashu:**cashuA...' to the QR so the app can be opened after using an external scanner (IOS camera, android camera or any other scanner)

Is your feature request related to a problem? Please describe.
Sometimes, the data for a cashu token is too big and can not fit in a QR code or the QR code pixels can be way too small so that some camera resolutions might not be able to scan it properly.

Describe the solution you'd like
An animated QR is a potential solution for cashu tokens that include a lot of proofs.

The cashu R&D Group is proposing a few Implementation possibilities:

cashubtc/cashu-ts#76

https://github.com/gre/qrloop

Provide a settings option that can enable or disable this feature.

Image used by expo:
https://github.com/KKA11010/eNuts/blob/main/assets/adaptive-icon.png

Expo icon docs:
https://docs.expo.dev/develop/user-interface/app-icons/

Current output:

Help:
https://developer.android.com/develop/ui/views/launch/icon_design_adaptive

@BilligsterUser, I'm mentioning and assigning you to provide an overview of my post-PR plan.

The code is nearly set for the beta release. Some remaining TODOs require discussion for further plan improvement.

To dos:

• Generate a downloadable and installable .APK beta build, attaching it to the BETA release notes.
• Proceed with the Apple Developer account and TestFlight steps.
• Update ios build script and ios config with necessary app IDs and dev account IDs.
• Generate an iOS .ipa build, submitting it to Apple for TestFlight release.
• Add verification hashes for released apk's
• Include the eNuts TestFlight invitation code in the BETA release notes.

Production workflow

• Create an automated workflow -> Use a PR into the main branch for preview builds to test upcoming updates before merging into the main branch.
• Created automated workflow -> use release tags with the format "v*" to create production builds

Additional

• Hide the hard coded test mint on production builds
• Host a mint where eNuts acts as the custodian.
• Establish a Lightning address (likely the enuts mint) as a developer fund for eNuts.
• Implement a tipping feature within the app for eNuts using LN (and Ecash).
• Create a simple website for eNuts

• "It is a standard iOS convention to position the back settings on the left. This design is consistent across numerous apps, including default iOS apps like Photos and Settings."

@swedishfrenchpress

Can be nice to have but currently has a low priority.

Provide flags for filtering TXs

• Lightning
• Ecash
• Sent
• Received

Additional filter options:

• Min. amount
• Date Range

Orientation on which files have to be modified:

https://github.com/cashubtc/eNuts/blob/main/src/components/screens/History/index.tsx#L22

Description will be added here ASAP

Use catch block to show a message that opening the link does not work

https://github.com/cashubtc/eNuts/blob/main/src/util/index.ts#L178

Describe the bug
Styling padding issue in the height of a flashlist row

Will provide a new release with a fix today

Describe the bug
QR code icon takes me back to the home screen

To Reproduce
Steps to reproduce the behavior:

1. Go to 'Contacts'
2. Click on 'QR icon' in top nav
3. See error

Expected behavior
Redirect to QR scan screen

Enhance the user experience on first visit of contacts screen

If the sole action available to the user when adding a mint is to copy and paste a mint URL, it might be beneficial to eliminate the Flotation Action Button (FAB) that initiates the add mint process.

Is your feature request related to a problem? Please describe.
I can not change the npub I provided for syncing my nostr follow list in the beginning

Describe the solution you'd like
Provide the possibility to change my personal npub

See:
https://maestro.mobile.dev/

Update: Using Detox now