casey / bak Goto Github PK

Two instances of bak can clobber each others backups. Since bak is explicitly intended to save data, users probably don't want this. So, bak should never clobber data. I suspect fixing this will probably involve forsaking std::fs::rename for something os-specific.

Ideally, bak should keep trying until it successfully renames a file.

If a directory contains foo, foo.bak.12, and foo.bak.13, should bak::move_aside("foo") create foo.bak, or foo.bak.14?

bak currently considers all non-utf8 sequences to be equal. In super esoteric fringe cases, this leads bak to pick a higher number for backups than necessary. Once OsStrs have functionality on par with strs, we can easily fix this. See rust-lang/rust#49802 for more details.