carlynorama / arduino-library-button Goto Github PK
View Code? Open in Web Editor NEWThis is a library for adding buttons to Arduino projects. It supports events like OnPress and OnRelease.
This is a library for adding buttons to Arduino projects. It supports events like OnPress and OnRelease.
I was just trying to understand how to create pull request. Is issue shouldn't be there.
I'd like to see an option when you initialize a button you can enable the internal pull-up resistor. Something like
Button MyPushButton = Button(9, LOW, true);
Where the 3rd parameter would be pull-up resistor enabled or disabled.
hi how to get just one output
onPress or DoubleClick?
so I could read the same button is clicked once or double?
if I use simply your library and choose onPress function and onDoubleClick for the same button,
then even when I press button twice for double click, it will recognize both, single and double,
could you tell me how to use those both functions for the same button?
Please use tabulations or spaces but newer use both. This makes you code absolutely unreadable.
Or pull #3
Please don't write like this:
if (_justPressed) {
_pToggleFlag ? _pToggleFlag=false : _pToggleFlag=true;
}
Write like this:
_pToggleFlag = !_pToggleFlag;
It is much faster and much more readable.
Or pull #3
These names are reserved for compiler and their usage leads to undefined behavior. Your library just is not guaranteed to work.
Instead of
//---------------------------------------------------- onPress
bool Button::onPress(void){
return _justPressed;
}
//------------------------------------------------ overload
bool Button::onPress(bool refreshPinData){
if (refreshPinData) {
listen();
return onPress();
} else {
return onPress();
}
}```
You can write just
Header:
bool Button::onPress(bool refreshPinData=false);
Source:
bool Button::onPress(bool refreshPinData){
if (refreshPinData) {
listen();
}
return justPressed_;
}```
Whic is much shorter and therefore much more readable. And calling to onPress(true) would be much faster.
Or pull #3
A declarative, efficient, and flexible JavaScript library for building user interfaces.
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
An Open Source Machine Learning Framework for Everyone
The Web framework for perfectionists with deadlines.
A PHP framework for web artisans
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
Some thing interesting about web. New door for the world.
A server is a program made to process requests and deliver data to clients.
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
Some thing interesting about visualization, use data art
Some thing interesting about game, make everyone happy.
We are working to build community through open source technology. NB: members must have two-factor auth.
Open source projects and samples from Microsoft.
Google ❤️ Open Source for everyone.
Alibaba Open Source for everyone
Data-Driven Documents codes.
China tencent open source team.