carlynorama / arduino-library-button Goto Github PK

These names are reserved for compiler and their usage leads to undefined behavior. Your library just is not guaranteed to work.

Please use tabulations or spaces but newer use both. This makes you code absolutely unreadable.
Or pull #3

I was just trying to understand how to create pull request. Is issue shouldn't be there.

hi how to get just one output
onPress or DoubleClick?
so I could read the same button is clicked once or double?
if I use simply your library and choose onPress function and onDoubleClick for the same button,
then even when I press button twice for double click, it will recognize both, single and double,

could you tell me how to use those both functions for the same button?

I'd like to see an option when you initialize a button you can enable the internal pull-up resistor. Something like
Button MyPushButton = Button(9, LOW, true);

Where the 3rd parameter would be pull-up resistor enabled or disabled.

Please don't write like this:
if (_justPressed) { 
_pToggleFlag ? _pToggleFlag=false : _pToggleFlag=true; 
}
Write like this:
_pToggleFlag = !_pToggleFlag;

It is much faster and much more readable.

Or pull #3

Instead of

//---------------------------------------------------- onPress 
bool Button::onPress(void){
    return _justPressed;
}   
//------------------------------------------------ overload
    
bool Button::onPress(bool refreshPinData){
    if (refreshPinData) {   
      listen();
      return onPress();  
    } else {
      return onPress(); 
    }
}```

You can write just 

Header:
bool Button::onPress(bool refreshPinData=false);
Source:
bool Button::onPress(bool refreshPinData){
if (refreshPinData) {
listen();
}
return justPressed_;
}```
Whic is much shorter and therefore much more readable. And calling to onPress(true) would be much faster.

Or pull #3