Is your feature request related to a problem? Please describe.

A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]

• N/A

Describe the solution you'd like

A clear and concise description of what you want to happen.

• Workflow to uniformly format the entire codebase, instead of relying on individual linting
• Refactor to reflect the rest of the repository's naming convention

Describe alternatives you've considered

A clear and concise description of any alternative solutions or features you've considered.

• N/A

Additional context

Add any other context or screenshots about the feature request here.

• Finding a simple and effective way to organize the codebase

Describe the bug

1. Currently, the GitHub workflow main.yml is failing.
   

2. The file history/img/plot.png doesn't exist in the repository.

3. However, the workflow is still referring to it and attempts to make a commit:
   

   devo-abastecer/.github/workflows/main.yml

   Line 36 in 010431a

   git add history/img/plot.png

Expected behaviour

• The GitHub workflow main.yml executes as usual.

To Reproduce

• Trigger the GitHub workflow: main.yml

Additional context

• N/A

Expected Behavior

At this moment, we have a scrapper that reads a JORAM PDF file and returns a dictionary with the gas prices. You can check the scrapper in this file.

• The PDF files can be found in this link;
• The weekly gas prices are issued on Thursdays or Fridays (most of them on Fridays);
• The 2.º Suplemento PDF files are the ones that contain gas prices (but not all of them).

You can check some examples here:

Actual Behavior

The gas prices are retrieved from the Direção Regional de Economia e Transportes Terrestres website.

However, these prices are not updated every Friday (as the JORAM document is issued with gas prices for the next week), so sometimes we can get the gas prices after the current week and don't have the info in time.

To check how we retrieve the gas prices at this moment, check this file.

Describe the issue

The constants.py currently refers to the year 2023 due to debugging reasons.

Describe the solution you'd like

As per PR #58:

• The JORAM website published the page for the year 2024 (Link)
• The reference for the year needs to be changed from 2023 to {date:%Y}

Additional context

# JORAM link 2023 - For Debugging
- JORAM_LINK = "https://joram.madeira.gov.pt/joram/2serie/Ano%20de%202023"
- JORAM_PDF_LINK = "https://joram.madeira.gov.pt/joram/2serie/Ano%20de%202023/{file}"
+ #JORAM_LINK = "https://joram.madeira.gov.pt/joram/2serie/Ano%20de%202023"
+ #JORAM_PDF_LINK = "https://joram.madeira.gov.pt/joram/2serie/Ano%20de%202023/{file}"

# JORAM link
- #JORAM_LINK = "https://joram.madeira.gov.pt/joram/2serie/Ano%20de%20{date:%Y}"
- #JORAM_PDF_LINK = "https://joram.madeira.gov.pt/joram/2serie/Ano%20de%20{date:%Y}/{file}"
+ JORAM_LINK = "https://joram.madeira.gov.pt/joram/2serie/Ano%20de%20{date:%Y}"
+ JORAM_PDF_LINK = "https://joram.madeira.gov.pt/joram/2serie/Ano%20de%20{date:%Y}/{file}"

Expected Behavior

We could generate and upload the plots from a Jupyter Notebook, as @HarryVasanth has suggested here.

Actual Behavior

After having this PR merged, we'll have a gas variation from the last six months being deployed, having also the images being stored in the repo.

Expected Behavior

When the file gas_info.json is changed, it should publish the tweet message.

Actual Behavior

There's a pipeline (main.yml) with a cronjob that verifies if new gas prices were released. If that happens, a commit is triggered by a pipeline. Then, there's another pipeline (create_tweet.yml) that should be triggered to run the tweet.py file. However, at this moment, this pipeline is not triggered.

Describe the bug

_{A clear and concise description of what the bug is.}

Gas dates have a delay of one week, even if the prices are the most recent ones.

Expected behaviour

_{A clear and concise description of what you expected to happen.}

It should return the correct gas dates, considering that PDF creation date have prices for the following week.

To Reproduce

_{Steps to reproduce the behaviour:} >

1. Go to '...'
2. Click on '....'
3. Scroll down to '....'
4. See error
   

Additional context

_{Add any other context about the problem here.}

Expected Behavior

➡️ Run python script.py > gas_info.json

  python script.py > gas_info.json
  shell: /usr/bin/bash -e {0}
  env:
    pythonLocation: /opt/hostedtoolcache/Python/[3](https://github.com/carlosrsabreu/devo-abastecer/runs/6851627521?check_suite_focus=true#step:5:3).10.[4](https://github.com/carlosrsabreu/devo-abastecer/runs/6851627521?check_suite_focus=true#step:5:4)/x[6](https://github.com/carlosrsabreu/devo-abastecer/runs/6851627521?check_suite_focus=true#step:5:6)4
    LD_LIBRARY_PATH: /opt/hostedtoolcache/Python/3.10.4/x64/lib

Actual Behavior

➡️ Run python script.py > gas_info.json

Traceback (most recent call last):
  File "/home/runner/work/devo-abastecer/devo-abastecer/script.py", line 32, in <module>
    start_date, end_date = gas_info[i].replace('.', '-').split('\xa0a ')
ValueError: not enough values to unpack (expected 2, got 1)

Error: Process completed with exit code 1.

Steps to Reproduce the Problem

1. The issue currently exists in all branches.
2. The issue can be reproduced by running the workflow manually or on schedule.

Describe the bug
The current pipeline is failing:

• First failed action in this sequence

Expected behaviour
Successful pipeline execution:

• Last succeeded action

To Reproduce
Execute the principal action

Additional context
The current pipeline is failing due to the formatting issues with latest PDF by JORAM

Is your feature request related to a problem? Please describe.

_{A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]}

We need to improve our local tests, so we can have our *.py files cleaned out of debug code.

Describe the solution you'd like

_{A clear and concise description of what you want to happen.}

As suggested by the @joaoofreitas:

• Remove Debug info and maybe create a python test file;
• Encapsulate debug code inside a callable function for testing and re-usability.

Describe alternatives you've considered

_{A clear and concise description of any alternative solutions or features you've considered.}

N.A.

Additional context

_{Add any other context or screenshots about the feature request here.}

# FIXME (DEBUG) Print se the filename to scrape the content
print(newest_pdf_filename)
# FIXME (DEBUG): Working link to Joram PDF
debug_pdf_joram = "https://joram.madeira.gov.pt/joram/2serie/Ano%20de%202022/IISerie-138-2022-07-22Supl.pdf"
Tip

Expected Behaviour

• The readme reflects the repository in adequate detail
• The issue templates supports both bugs and features/enhancements
• The pull request template facilitates the assignee

Actual Behaviour

• Descriptive readme
• Boiler plate issue template
• Boiler plate pull request template

Describe the bug

_{The commit messages, in GH Actions, are authored by me.}

Expected behaviour

_{The commit messages must be authored by GH Bot}

Expected Behavior

The prices should be retrieved from the JORAM website. The weekly gas prices are issued every Friday, in 2.º Suplemento. You can check some examples here:

Actual Behavior

Right now, the gas prices are retrieved from the Direção Regional de Economia e Transportes Terrestres website. However, these prices are not updated every Friday (as the JORAM document is issued with gas prices for the next week).

To check how we retrieve the gas prices at this moment, check this file.

Is your feature request related to a problem? Please describe.

_{A clear and concise description of the problem. Ex. I'm always frustrated when [...]}

We should drop DRET gas prices (they are unstable and the format constantly changes).

Describe the solution you'd like

_{A clear and concise description of what you want to happen.}

Use JORAM gas prices (more stable, using the same format).

Describe alternatives you've considered

_{A clear and concise description of any alternative solutions or features you've considered.}

Additional context

_{Add any other context or screenshots about the feature request here.}

Expected Behavior

➡️ Run python script.py

Run python script.py
  python script.py
  shell: /usr/bin/bash -e {0}
  env:
    pythonLocation: /opt/hostedtoolcache/Python/[3](https://github.com/carlosrsabreu/devo-abastecer/actions/runs/3855845927/jobs/6571353639#step:5:3).11.1/x6[4](https://github.com/carlosrsabreu/devo-abastecer/actions/runs/3855845927/jobs/6571353639#step:5:4)

Actual Behavior

➡️ Run python script.py

Run python script.py
  python script.py
  shell: /usr/bin/bash -e {0}
  env:
    pythonLocation: /opt/hostedtoolcache/Python/[3](https://github.com/carlosrsabreu/devo-abastecer/actions/runs/3856013359/jobs/6571714706#step:5:3).11.1/x6[4](https://github.com/carlosrsabreu/devo-abastecer/actions/runs/3856013359/jobs/6571714706#step:5:4)

Traceback (most recent call last):
  File "/home/runner/work/devo-abastecer/devo-abastecer/script.py", line [5](https://github.com/carlosrsabreu/devo-abastecer/actions/runs/3856013359/jobs/6571714706#step:5:5)[8](https://github.com/carlosrsabreu/devo-abastecer/actions/runs/3856013359/jobs/6571714706#step:5:8), in <module>
    price = float(gas_info[i + 1][:-1].replace(',', '.'))
            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
ValueError: could not convert string to float: 'Gasolina IO[9](https://github.com/carlosrsabreu/devo-abastecer/actions/runs/3856013359/jobs/6571714706#step:5:9)'
Error: Process completed with exit code 1.

Steps to Reproduce the Problem

1. The issue currently exists in all branches.
2. The issue can be reproduced by running the workflow manually or on schedule.