carlelieser / tiper-js Goto Github PK

There are several variables, properties and functions which are not used. Should they be removed / should stay?

Hi @carlelieser.

A new version of set-interval-async is available with improvements on error handling and including a bug fix. You may see the changes in more detail in the release notes.

I'm reaching out because I noticed an instance of the following pattern in your project, which may lead to undesired results:

const timer = setIntervalAsync(async () => {
  // ...
  if (/* some condition */) {
    await clearIntervalAsync(timer);
  }
}, interval);

The code above generates a chaining promise cycle which never resolves, because:

• await clearIntervalAsync(timer) will not resolve until the last execution has finished, AND
• the last execution will not finish until await clearIntervalAsync(timer) has been resolved.

In tiper-js, the pattern is hidden in the following sequence initializeTypingInterval > setIntervalAsync > insertCurrentChar > stopTyping > clearIntervalAsync. Simply not awaiting clearIntervalAsync may be enough to avoid this issue, but the right solution will depend on your application's requirements. This didn't surface earlier due to the bug in set-interval-async that has now been fixed in the latest major version.

stopTyping() this method doesn't work

To ensure the code is consistent, linter could be added, for example eslint with typescript plugins