Code Monkey home page Code Monkey logo

devexchangebot's People

Contributors

coolgabrijel avatar justaeris avatar

Stargazers

 avatar  avatar

Watchers

 avatar  avatar

devexchangebot's Issues

Fix public static DiscordClient property in Program class

The Program.cs file contains the following comment:

// TODO: The client class shouldn't be public, but there are
// compatibility issues with the role menu system if we make
// this private. This needs fixing.

This problem is created due to the usage of the Program.Client in RoleMenuModel.GetAllEmojis(). This should be fixed, as outlined in the comment, it is bad practice to have the DiscordClient object staticly availably.

Update DSharpPlus to stable branch (4.1.0)

The DSharpPlus version the bot is currently using is 4.1.0-nightly-00930. Recently, stable version 4.1.0 has come out which provides the same features without using the nightly build sources. The problem here is that the nightly sources seem to have become unavailable making it impossible to compile and run the bot anymore.

My suggestion would be to switch from the nightly build to the stable 4.1.0 version of DSharpPlus. It comes with the same features without the hassle of having to add additional NuGet sources to pull in the right packages. The bot is stable as-is, so nightly build sources would not be needed at this point.

Resolve the Discord Guild emoji vs. unicode emoji issue

The RoleMenuModel.cs class contains the following comment:

// DiscordEmoji.FromName() doesn't work with Unicode
// and DiscordEmoji.FromUnicode() doesn't work with Custom Guild Emojis
// So we have to do this stupid thing where Unicode emojis have no ID and Guild Emojis have no Unicode
// and when getting the Role we check if the RoleBind id is 0
// if it is then we yoink it via DiscordEmoji.FromUnicode() otherwise DiscordEmoji.FromGuildEmote()

// If anyone wants to fix it => I wish you good luck.

This seems to depend on the way Discord is handling emojis. There got to be a better way to fix this... Maybe there's a way to introduce a permanent solution to this problem that can be used consistently throughout the codebase?

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.