canonn-science / edmc-canonn Goto Github PK

Add a button to allow the news to be progressed.

Is it possible to add a plugin level catch of unexpected errors so that, at worst, the plugin stops working but EDMC doesn’t crash

What version are you running
1.8.0

Describe the bug
The buttons are taking seconds to refresh

Expected behavior
Should be instant

Add patrols based on the legacy reports but it must be module so it can be updated to use strapi when done

There appears to be issues with import when the username has Cyrillic characters in their plugin directory path.

Going ahead with sub modules regardless and will come up with a solution later.

Looking for a solution from EDMC

Is your feature request related to a problem? Please describe.

The ship patrol cant be loaded until data is loaded from the Frontier servers of the cmdr docks. Therefore we can be left waiting for the update to happen. Saving a copy of the locations would allow the patrol to work even without an update

Describe the solution you'd like

Save a copy of the ship locations in the plugin directory.
On exit make sure the file is copied.
Optionally update the ship locations when there is an event.

What version are you running
1.7.2

Describe the bug
Under some conditions the release section says fetching and doesn't update

To Reproduce

Unknown

Screenshots
If applicable, add screenshots to help explain your problem.

Is your feature request related to a problem? Please describe.
We want to be able to turn off clients on versions of the software that are problematic.

Describe the solution you'd like
On startup, look up the client blacklist from Strapi.
If the client version is blacklisted display a message saying the client is blacklisted and a link to the wiki
Disable all functionality

WentbackwardToday at 6:10 AM
Hi ... having some problems with EDMC crashing out which meant my faction kills not updating ... have not narrowed down any particular cause but during debug noticed these errors in the logs 2019-07-20 12:26:04.643000 [EDMC-Canonn.2.3.0] Suhte: Canonn Influence 31.37% States: civilliberty Please complete missions for Canonn to increase our influence
Traceback (most recent call last):
File "plug.pyo", line 365, in notify_newdata
File "C:\Users\paul\AppData\Local\EDMarketConnector\plugins\EDMC-Canonn-2.3.0\load.py", line 226, in cmdr_data
File "C:\Users\paul\AppData\Local\EDMarketConnector\plugins\EDMC-Canonn-2.3.0\canonn\patrol.py", line 776, in cmdr_data
File "C:\Users\paul\AppData\Local\EDMarketConnector\plugins\EDMC-Canonn-2.3.0\canonn\patrol.py", line 98, in getShipType
AttributeError: 'NoneType' object has no attribute 'lower'

Is your feature request related to a problem? Please describe.
Some patrols may simply require an event to be detected when in system to allow the report to be automatically submitted.

Eg. Jump to the system just requires a FSD jump
FSS Scan requires a FSS all signals complete

Describe the solution you'd like
The patrol can have an extra field for event. The field will contain a dict. The patrol will check if the values in the dicts are met and will submit the url if not blank and call the click_next procedure.

Create a new module legacy

This should submit reports to the google sheets as before.

What version are you running
1.9.0

Describe the bug
Codex entries in regions with commas in the name generate an error when they are logged.
This is because the unicode doesnt play nicely

To Reproduce
Fly to any of the following regions and trigger a codex event

Ryker's Hope
Odin's Hold
Newton's Vault
Hawking's Gap
Dryman's Point
Aquila's Halo
Achilles's Altar
Lyra's Song
Kepler's Crest

** Log Files **

Log file

Traceback (most recent call last):
  File "plug.pyo", line 302, in notify_journal_entry
  File "C:\Users\DOOM\AppData\Local\EDMarketConnector\plugins\EDMC-Canonn-1.9.0\load.py", line 141, in journal_entry
  File "C:\Users\DOOM\AppData\Local\EDMarketConnector\plugins\EDMC-Canonn-1.9.0\load.py", line 156, in journal_entry_wrapper
  File "C:\Users\DOOM\AppData\Local\EDMarketConnector\plugins\EDMC-Canonn-1.9.0\canonn\legacy.py", line 79, in CodexEntry
  File "urllib.pyo", line 1303, in quote_plus
  File "urllib.pyo", line 1298, in quote
KeyError: u'\u2019'

Additional context
Add any other context about the problem here.

Clicking on system name should take you to the EDSM system page so you can get an advance look at the system

• For Canonn patrols this should take you to EDSM
• For BGS patrol this could have alternative behaviour
• For Ships patrol this should link to EDSM ship page

What is your commander name

Reported on facebook

What version are you running

Unknown

Describe the bug

After the upgrade, no copy of the plugin was installed and the new version was missing

To Reproduce

Unknown

The auto-update feature needs to have a lot more error handling to prevent a loss of the plugin

Scenarios as follows:

• Unable to access github
• Unable to download zipfile
• Zipfile corrupted
• Unable to unzip
• Unable to rename current directory
• Backup dir already exists
• Unable to delete backup directory

Need to make it possible to skip patrols at least in the current session.

• Skip when the users clicks on the link
• Skip when the user clicks on the skip button
• Clicking on the patrols label clears the skip list

Is your feature request related to a problem? Please describe.

If I create a release and forget to update the version number in load.py then users could end up in a perpetual upgrade loop.

Describe the solution you'd like

I'd like the git tag to be included in Source.zip somewhere so that when a release is created we can pick up the version number automagically

This would work for normal installations but would not work with people directly extracting from github.

Describe alternatives you've considered

• Using the directory name..
• Copying a tag file on install

Is your feature request related to a problem? Please describe.
Automatically copy the patrol system name to the clip board

Describe the solution you'd like
Add an option to enable autocopy to the settings page
in getNearest, if autocopy is set then copy the systemname

What is your commander name

Space based codex data not getting loaded in gSubmitCodex. Check logs on google

What version are you running

1.9.7

Is your feature request related to a problem? Please describe.
Strapi is single threaded so long requests can block. Breaking the requests into pages ensure no long running queries will block other users.

What version are you running
1.9.1

Describe the bug
FSS Exclude url was wrong and the AX reports weren't being updated.

To Reproduce
Go to a system with AX CZ and FSS Scan

Still getting some issues with random crashes.

Will need to make sure that there are no tkinter objects being accessed

Example from Codex Reports:

Required API POST Format:

POST /tbreports

{
  "userType": "pc",
  "reportType": "new",
  "systemName": "string",
  "systemAddress": 0,
  "regionID": 0,
  "coordX": 0,
  "coordY": 0,
  "coordZ": 0,
  "bodyName": "string",
  "latitude": 0,
  "longitude": 0,
  "type": "Journal Name",
  "cmdrName": "string",
  "isBeta": false,
  "clientVersion": "string",
  "reportStatus": "pending"
}

Is your feature request related to a problem? Please describe.

Some people have had double installations. We need some code to identify if we are in a double install scenario and prompt to delete old versions

Is your feature request related to a problem? Please describe.

Occasionally we have events where we want to log commodity sales.

Describe the solution you'd like

A white list lookup for systems we want to log at startup.

Then after startup we can use the whitelist to log the data.

Describe alternatives you've considered

Additional context

Traceback (most recent call last):
File "plug.pyo", line 302, in notify_journal_entry
File "C:\Users\reneo\AppData\Local\EDMarketConnector\plugins\EDMC-USS-Survey\load.py", line 938, in journal_entry
File "C:\Users\reneo\AppData\Local\EDMarketConnector\plugins\EDMC-USS-Survey\load.py", line 957, in journal_entry_wrapper
File "C:\Users\reneo\AppData\Local\EDMarketConnector\plugins\EDMC-USS-Survey\load.py", line 1071, in CodexEntry
File "urllib.pyo", line 1303, in quote_plus
File "urllib.pyo", line 1298, in quote
KeyError: u'\u2019'

Looks like unicode issues

{ "timestamp":"2019-01-12T01:39:17Z", "event":"Music", "MusicTrack":"Codex" }
{ "timestamp":"2019-01-25T22:46:36Z", "event":"CodexEntry", "EntryID":1301801, "Name":"$Codex_Ent_Standard_Ter_Ice_Name;", "Name_Localised":"Non Terraformable", "SubCategory":"$Codex_SubCategory_Terrestrials;", "SubCategory_Localised":"Terrestrial planets", "Category":"$Codex_Category_StellarBodies;", "Category_Localised":"Astronomical Bodies", "Region":"$Codex_RegionName_4;", "Region_Localised":"Odin’s Hold", "System":"Dryooe Prou HD-X b48-62", "SystemAddress":136876714968993, "IsNewEntry":true }

Is your feature request related to a problem? Please describe.
If you skip patrols and exit EDMC, when you come back in there skipped patrols have to be skipped again.

Describe the solution you'd like
Given that restoring a skipped patrol is easy enough using the back button we might as well save the skipped reports to disk.

Describe alternatives you've considered
Considered having a button appear when you skip to make it permanent.

Is your feature request related to a problem? Please describe.
People who don't upgrade ARE CORRUPTING MY DATA!

Describe the solution you'd like
Install a sub space receiver in each ship that can be used to initiate the self destruct sequence from the comfort of my ship.

Describe alternatives you've considered

• compulsory upgrades
• client blacklisting

What is your commander name

test
What version are you running

Describe the bug

To Reproduce

Expected behavior

Screenshots

Log Files

Additional context

What is your commander name

Roman Sharp

What version are you running

1.9.7

Describe the bug

If there are Cyrillic characters on the way to the plug-in folder, the settings disappear, and the main window looks like this [1]
To Reproduce

Expected behavior

Screenshots

Log Files

EDMarketConnector (2).log
Additional context

Change the news widget to use the arrow keys like the patrols.

We could remove the automatic cycling or make it optional.

Describe the bug
Docked at Ceos with two ships but the patrol is only naming the one ship

Expected behavior
Expecting it to tell me about two ships

Is your feature request related to a problem? Please describe.
The patrol configuration needs to live inside the plugin directory, But the upgrade does not keep the old directory.

Describe the solution you'd like
When we save the configuarion we will need to detect if an upgrade has taken place and make sure that the file is saved to the correct directory. NB: After an upgrade the current directory will have been renamed so saving locally would not work anyway

Is your feature request related to a problem? Please describe.
Per your request on discord we should include the CAPIv2 alerts in the news ticket:
https://api.canonn.tech:2083/alerts

Example:

[
    {
        "id": 7,
        "title": "EDMC-Canonn Plugin release",
        "body": "Add some link like https://github.com/canonn-science/EDMC-Canonn/releases/latest\n\nMaybe add a few patch notes.\n\nBlah blah blah some text here.\n\nUpdated alert without image",
        "alertLevel": 3,
        "active": true,
        "tldr": "New release for EDMC-Canonn v2.9.49",
        "alertURL": "https://github.com/canonn-science/EDMC-Canonn/releases/latest",
        "created_at": "2019-03-26T12:26:48.000Z",
        "updated_at": "2019-03-26T12:30:11.000Z",
        "alertImage": false
    }
]

Describe the solution you'd like
Based on the alert level the alert should show up with a "higher" priority ASAP. This would allow us to push alerts to users ASAP as well.

The codex is able to determine which url to send based on a lookup on live

• factionkill
• hdreport
• journaldata
• nhss

Is your feature request related to a problem? Please describe.
We want to be able to show people AX CZ patrols. However the AX CZs are volatile, so we need to be able to remove them from the reports quite quickly.

Describe the solution you'd like
We need a list of AX CZ locations that we can select where the date is more recent than the last tick. eg Thursday 5am
When the user travels to the AX if the AX site is no longer present then the commander should be able to remove it from the list by submitting a report.

Describe alternatives you've considered
We could change the report to only show the AX site if it has been reported in the last 24 hours, however if no commanders visit then we could end up not showing active AX sites.

Alternatively we show the AX site but also display the last date/time to give an idea of how old it is.

Is your feature request related to a problem? Please describe.
No problem

Describe the solution you'd like
Send the Guardian Beacon report, take a screenshot of the message, use the reportID and upload screenshot to CAPIv2 via the upload plugin. Manual verification of message will be required.

Describe alternatives you've considered
Tweak the current screenshot plugin to do so

Additional context

What version are you running
1.7.2

Describe the bug
The excludeevents model contains the Shutdown event. But shutdown is still being logged to the journal

To Reproduce
Fly around normally

Expected behavior
Excluded events should not appear in the reportevents model

commit 4f58fe4

Describe the bug
Sometimes the Plugin is stuck in a Resize Loop for the Patrol or Message Text Field, which makes the whole EDMC stutter, which sometimes causes the whole EDMC to crash silently.

To Reproduce
No Idea.

Expected behavior
Patrols and Canonn should create a stable window

Screenshots

Log Files

Additional context

Is your feature request related to a problem? Please describe.
We would like to capture the full hyperdiction history from the player logs

Describe the solution you'd like
Provide a button on the config screen or UI that the user can use to trigger a scan of the player journal for hyperdictions. The button should no longer be available after first use. It should look up the player's hyperdiction history from the API and not submit duplicates.

Is your feature request related to a problem? Please describe.

I'd like to have an indicator that shows me where I am in relation to merope and also whether NHSS have been spotted in the current system and if a Thargoid site is present.

This will prompt me to look for NHSS if I jump into a system that has none.

Describe the solution you'd like

Enhance the POIList feature to bring back NHSS data and TSS data. Then we only hit the API once

A list of all BGS stats can be obtained from elitebgs

https://elitebgs.app/api/ebgs/v4/factions?name=Canonn
https://elitebgs.app/api/ebgs/v4/factions?name=Canonn+Deep+Space+Research
https://elitebgs.app/api/ebgs/v4/factions?name=Canonn+Gnosis+Division

The patrol instructions can include some analysis of the stats and application of standing orders.

Eg Our influence is 80% please do missions for other factions

• Display Influence %
• Display Current States
• Display Pending states
• Standing orders below 50%
• Standing orders over 65%
• Standing orders on target
• Time sensitivity
• Spreadsheet override for exceptional systems

Based on the following Journal log:

{ "timestamp":"2018-03-03T16:52:53Z", "event":"ApproachSettlement", "Name":"$Ancient_Tiny_002;", "Name_Localised":"Guardian Structure", "MarketID":2952790784 }

We should be able to do automated GS reports (GR still not likely due to missing type)

Pulling System, Body, Latitude, and Longitude from the status.json combined with matching the above with https://api.canonn.tech/gstypes

It should be possible to automatically report GS, note that this entry is not a codex one thus /reporttypes doesn't apply here. It's an actual journal entry

What version are you running
Reporting on behalf of other users, but based on reports EDMC-Canonn.1.9.1

Describe the bug
Shutdown event is in the excludes list but is still being sent

To Reproduce
Example: https://api.canonn.tech:2083/reportevents?eventname=Shutdown

Expected behavior
Shutdown should not be sent to the CAPI as we don't need to store the data.

Screenshots
N/A

** Log Files **
No logs as this is reported from our side

Additional context
N/A

** What version are you running **
1.7.1

Describe the bug
When selecting a patrol target it is not possible to use the back button after going forward

To Reproduce

1. Click right to pick a new patrol
2. Jump
3. Click right
4. Click left.

Clicking left does not return to previous target

Expected behavior
A clear and concise description of what you expected to happen.

Screenshots
If applicable, add screenshots to help explain your problem.

** Log Files **
Look for error messages in AppData\Local\Temp\EDMarketConnector.log

Additional context
Add any other context about the problem here.

JUmping isint setting the index

This is because the names in the exclusion list have to be converted to match the journal.

Haven't accounted for case sensitivity.

Is your feature request related to a problem? Please describe.

Change the client routing code to use live/beta when the release number is one of the official releases unless the route is overridden by the clientroute

This will make it easier to manage new releases and quarantine old ones

More details on discord

What version are you running
1.9.4

Describe the bug

The edTimestamp is showing a different value from the in game timestamp in the raw data.

To Reproduce

Move to the Russia and kill some thargoids

Expected behavior

Timestamps should match

Screenshots

What version are you running
1.8.1

Describe the bug
On exit to the main menu. Then we you re-enter the game, It initially says waiting for location then the UI goes crazy flashing and then becomes unresponsive. It looks like it might be a problem with the News and Patrol both attempting to resize and triggering another resize event

In the logs it looks like we have multiple patrol refreshes,

This has happened twice after hyperdictions.

To Reproduce

1. Exit to the main menu.
2. Start the game

You may have to attempt this a few times to reproduce,

**Logs

2019-03-18 17:59:32.715000 [EDMC-Canonn.1.8.1] excluding: Synuefai ME-A c17-7
2019-03-18 17:59:33.310000 [EDMC-Canonn.1.8.1] https://api.canonn.tech:2083/hdreports?id=6643
2019-03-18 18:00:48.499000 [EDMC-Canonn.1.8.1] https://api.canonn.tech:2083/reportevents?id=54957
2019-03-18 18:00:53.085000 [EDMC-Canonn.1.8.1] Refresshing Patrol
2019-03-18 18:00:57.136000 [EDMC-Canonn.1.8.1] Refresshing Patrol
2019-03-18 18:00:57.230000 [EDMC-Canonn.1.8.1] Hyperdiction already recorded here - session
2019-03-18 18:00:57.833000 [EDMC-Canonn.1.8.1] https://api.canonn.tech:2083/reportevents?id=54963
2019-03-18 18:02:08.463000 [EDMC-Canonn.1.8.1] https://api.canonn.tech:2083/reportevents?id=54967
2019-03-18 18:02:13.178000 [EDMC-Canonn.1.8.1] Refresshing Patrol
2019-03-18 18:02:17.118000 [EDMC-Canonn.1.8.1] Refresshing Patrol
2019-03-18 18:02:17.218000 [EDMC-Canonn.1.8.1] Hyperdiction already recorded here - session
2019-03-18 18:02:17.825000 [EDMC-Canonn.1.8.1] https://api.canonn.tech:2083/reportevents?id=54973
2019-03-18 18:02:43.534000 [EDMC-Canonn.1.8.1] https://api.canonn.tech:2083/reportevents?id=54983
2019-03-18 18:02:50.604000 [EDMC-Canonn.1.8.1] Refresshing Patrol
2019-03-18 18:02:53.639000 [EDMC-Canonn.1.8.1] Refresshing Patrol