canonknipser / imthumbnailer Goto Github PK

Hi,
Would it be possible to have the thumbnailet work when inserting a remote image into a post, example:

[img]https://cursorium.co.uk/gallery/_data/i/upload/2018/06/11/20180611113938-c9a106df-me.jpg[/img]

As well as it working with attachments?
Regards
Chris

see: https://www.phpbb.com/customise/db/extension/imagemagick_thumbnailer/support/topic/198661?p=676201#p676201 - thanks to olalavui

Following https://www.phpbb.com/customise/db/extension/imagemagick_thumbnailer/support/topic/207596?p=704161#p704161

for png images setOption('png:compression-level', 9); should be used instead of setCompressionQuality()

Thanks to thecoalman

Extensions should follow a new directory structure - root is only containing non-packed resources, packed resources are in a subfolder named vendor/extension

Admins should be able to define a Filter used to resize a image, Currently, the filter is set to FILTER_LANCZOS

The extension pre validator found some issues

acp/main_module.php
event/main_listener.php

adm/style/acp_ck_it_body.html

you can use {{ lang('ACP_CK_IT_QUALITY') ~ lang('COLON') }} instead of {{ lang('ACP_CK_IT_QUALITY') }}{{ lang('COLON') }}.

Suggestion from the customizatioon team

public function is_enableable()
{
	$language = $this->container->get('language');
	$language->add_lang('imthumbnailer_acp', 'canonknipser/imthumbnailer');

	if (!class_exists('Imagick'))
	{
		trigger_error($language->lang('CK_IM_REQUIRE_IMAGICK'), E_USER_WARNING);
	}

	$config = $this->container->get('config');
	if (!phpbb_version_compare($config['version'], '3.2.4', '>='))
	{
		trigger_error($language->lang('CK_IM_REQUIRE_IMAGICK'), E_USER_WARNING);
	}
	
	return true;
}

clean code following coding guideline