Return code -1 about httpresponsecache HOT 14 CLOSED

Since you're using ICS, can you see if you can reproduce this bug without using this library?Just comment out the line that says: com.integralblue.httpresponsecache.HttpResponseCache.install(httpCacheDir, httpCacheSize)

from httpresponsecache.

I think that I must replace
com.integralblue.httpresponsecache.HttpResponseCache.install(httpCacheDir, httpCacheSize)
by
android.net.http.HttpResponseCache.install(httpCacheDir, httpCacheSize);
Not only comment out first one.
I will try it.

from httpresponsecache.

I think that this problem exist also on official implementation and I think that it happen when I use debugging more intensive and often kill and start the application. Maybe file cache implementation is not safe if application is killed.

from httpresponsecache.

I'm also seeing this issue. I'm going to look into a patch. This issue exists both in the officially released version and your compatibility version. See http://code.google.com/p/android/issues/detail?id=7787

from httpresponsecache.

I haven't seen this problem. All I did was close InputStream and disconnect URLConnection.

from httpresponsecache.

ResponseHeaders#combine is where the status line is lost because result does not have a status line set.

result.setStatusLine(headers.getStatusLine());

Fixes the issue just after the creation of the new RawHeaders object. Is that the right implementation, @candrews?

from httpresponsecache.

I'm thinking the status line should probably be of the network's status line (304 Not Modified) instead of the cached (200 OK)

result.setStatusLine(network.headers.getStatusLine());

from httpresponsecache.

See pull request (#10)

from httpresponsecache.

The fix makes sense to me. It seems to me that since this bug also affects ICS's HttpResponseCache implementation, that the same fix should be made there - could you create an issue in the Android bug tracker, and submit this fix to them?

I also asked the original author of this code in the Android project for his thoughts on the fix.

Thanks for you help - I look forward to having this fixed in this compatibility project and in Android itself soon!

from httpresponsecache.

Nevermind - Android already has this fix! See 5d7e0fc1af3141aa41e9c21d74da3c36b933517f in Android libcore

Thanks Jesse!

I'm currently copying all the changes from when I last updated this library, which was android-4.0.1_r1, to now (which is currently android-4.1.1_r3). This fix will be included.

from httpresponsecache.

I think upstream already has a fix:
http://omapzoom.org/?p=platform/libcore.git;a=blob;f=luni/src/main/java/libcore/net/http/ResponseHeaders.java;h=003b4457b95036c3b52136df493366fb527db568;hb=HEAD

update ... and now I read that you've seen that too. Sweet.

from httpresponsecache.

Thanks for looking into it and getting back to me. I saw an issue in the bug tracker that I thought was it but it looked like it was targeted for a much earlier version. I guess it was targeted, but not fixed until recently.

from httpresponsecache.

I finished merging in the Android changes up to version android-4.1.1_r3, and this fix is included. Please test and let me know if this issue occurs again. Thank you!

from httpresponsecache.

Is this failed test related to this issue?
Failed tests: testConditionalHitUpdatesCache(com.integralblue.httpresponsecache.compat.libcore.net.http.HttpResponseCacheTest): null expected:<[A]> but was:<[B]>

from httpresponsecache.