Code Monkey home page Code Monkey logo

Comments (5)

lkorth avatar lkorth commented on July 20, 2024

+1 this solves issue #32. Do we need to open a bug with Google and get this committed upstream? I had the same issues using the HttpResponseCache built in to Jelly Bean.

from httpresponsecache.

DanielLukic avatar DanielLukic commented on July 20, 2024

Do it! ^^

But I am not 100% convinced that this is a proper fix. Because we could create an IOException when reading ahead. So a proper fix probably needs to be a bit more sophisticated.

In a project I am working on right now I fixed this issue by moving the "read ahead" step into the close() method. Ignoring all exceptions. Not sure if this is any better.

Well, would not hurt to report this to Google, I guess. So please go ahead, if that is OK with you. I would not really know where to go.. ^^

dl

from httpresponsecache.

lkorth avatar lkorth commented on July 20, 2024

I have a feeling that a more complex fix is the right way to go, but this works for now for development.

@candrews thoughts?

from httpresponsecache.

candrews avatar candrews commented on July 20, 2024

A bug should definitely be opened with the Android project about this.

@swankjesse can you chime in? You wrote this, and presumably this effects some of the projects you're currently working on :)

from httpresponsecache.

swankjesse avatar swankjesse commented on July 20, 2024

Fixed in OkHttp! See Android issue 38817.

from httpresponsecache.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.