The candidewalletcontracts's discuss from candidelabs

candidelabs / candidewalletcontracts Goto Github PK

View Code? Open in Web Editor NEW

Smart contracts used by Candide Wallet

License: GNU General Public License v3.0

Solidity 64.97% JavaScript 0.69% TypeScript 34.34%

candidewalletcontracts's Issues

Update the wallet contracts to use the latest entrypoint

What is wrong ?

Update the wallet contracts to use the latest entrypoint at Goerli 0x0576a174D229E3cFA37253523E645A78A0C91B57

Unreachable code

The following modifier is not in use anywhere, and this affects coverage reports

CandideWalletContracts/contracts/modules/social_recovery/SocialRecoveryModule.sol

Lines 68 to 71 in 586d9cd

    
           modifier whenNotRecovery(address _wallet) { 
        
               require(recoveryRequests[_wallet].executeAfter == 0, "SM: ongoing recovery"); 
        
               _; 
        
           }

The following if condition will never be invoked because it's already satisfied by the require at line 81

CandideWalletContracts/contracts/modules/social_recovery/storage/GuardianStorage.sol

Lines 80 to 83 in 586d9cd

    
           // Validate that threshold is smaller than or equal to number of guardians. 
        
           require(_threshold <= entry.count, "GS: threshold must be lower or equal to guardians count"); 
        
           if (entry.count == 0){ 
        
               require(_threshold == 0, "GS: threshold must be 0");

Recommend Projects

React

A declarative, efficient, and flexible JavaScript library for building user interfaces.

Vue.js

🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

Typescript

TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

TensorFlow

An Open Source Machine Learning Framework for Everyone

Django

The Web framework for perfectionists with deadlines.

Laravel

A PHP framework for web artisans

D3

Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

javascript

JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

web

Some thing interesting about web. New door for the world.

server

A server is a program made to process requests and deliver data to clients.

Machine learning

Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

Visualization

Some thing interesting about visualization, use data art

Game

Some thing interesting about game, make everyone happy.

Recommend Org

Facebook

We are working to build community through open source technology. NB: members must have two-factor auth.

Microsoft

Open source projects and samples from Microsoft.

Google

Google ❤️ Open Source for everyone.

Alibaba

Alibaba Open Source for everyone

D3

Data-Driven Documents codes.

Tencent

China tencent open source team.

	modifier whenNotRecovery(address _wallet) {
	require(recoveryRequests[_wallet].executeAfter == 0, "SM: ongoing recovery");
	_;
	}

	// Validate that threshold is smaller than or equal to number of guardians.
	require(_threshold <= entry.count, "GS: threshold must be lower or equal to guardians count");
	if (entry.count == 0){
	require(_threshold == 0, "GS: threshold must be 0");