Code Monkey home page Code Monkey logo

bootstrap-portfolio's Introduction

bootstrap-porfolio

bootstrap-portfolio's People

Contributors

cancelei avatar

Stargazers

 avatar

Watchers

 avatar

bootstrap-portfolio's Issues

Morning Session- Code Review

Hi @cancelei ,

Congratulations! ๐ŸŽ‰ You made a great job on this project

Highlights

  • Descriptive PR โœ”๏ธ
  • Linters passing โœ”๏ธ

Optional Suggestions ๐Ÿ’ก

  • While these comments with the [OPTIONAL] prefix won't prevent the approval of this pull request, I strongly recommend taking them into account as they can improve your code. Some of them were missed by the previous reviewer and addressing them will really enhance your application.
  • I will suggest having one media query for mobile define rules and after all the other sizes will take the normal properties.

Cheers and Happy coding!๐Ÿ‘๐Ÿ‘๐Ÿ‘

If you have any questions or need clarification on anything, feel free to leave a comment in the pull request thread, and don't forget to tag me so I'll receive the notification.


As per the Code reviews limits policy, you have a limited number of reviews per project. If you feel that the code review was unfair, you can request a second opinion using this form.

Once again, congratulations on completing this project! ๐ŸŽ‰

Morning Session Review

Great progress so far!
Here are a few issues to consider :
The following properties can be replaced with bootstrap classes.
1. Height and width
2. Justify-content: center and justify-content: space-around
3. background-color

Good Luck and Happy Coding ๐Ÿ˜

Bootstrap classes vs CSS classes

Nice work ๐Ÿ‘ Keep up the good work ๐Ÿ‘ ๐Ÿ‘. One thing I would like to call your attention to, is using the same bootstrap class name in your css style sheet. I think it would be better if you don't use the same class name in your css file so as not not to alter some of the bootstrap styling, or what do you think?

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.