cakesolutions / sbt-cake Goto Github PK

in enablePlay

    wartremoverExcluded in Compile ++= play.sbt.routes.RoutesKeys.routes.in(Compile).value

When the name has an non variable supporting character, you will see an error like

scala-2.12/src_managed/main/sbt-buildinfo/BuildInfo.scala:1: '{' expected but identifier found.

It'd be really useful to include the https://github.com/jrudolph/sbt-dependency-graph in the standard set of plugins.

https://github.com/danielnixon/sbt-ignore-play-generated/blob/master/src/main/scala/org/danielnixon/settings/Scoverage.scala#L9

 Seq(scoverage.ScoverageKeys.coverageExcludedPackages := "controllers.javascript*;controllers.ref*;router*")

would be a nice convenience to have

It should be mandatory for all projects to be able to report on what software licenses they are using (amongst their respective library dependencies).

sbt-license-report provides us with the ability to generate license reports on a per module basis. This plugin should be added into sbt-cake and then enabled and used on all master branch builds.

My comments on the configuration of these plugins. I'd like to see a process of consensus and refinement.

In general and in my opinion the checks are too strict to be widely agreeable. A more lenient set of checks that provide the most value should be the objective.

Scalastyle + scalafmt:

• 80 line width is too small. Suggest 120 at least.

Scalastyle:

• Error level is too strict. Warning is sufficient.

Wart remover:
Seems to report a lot of questionable and opinionated issues. I would prefer to loosen the checks. Sprinkling suppress warnings annotations around the codebase is not ideal.

• discarded non-Unit value
• Function has default arguments (crazy)
• case classes must be final (pointless)
• Inferred type containing Any
• Statements must return Unit
• throw is disabled (pointless)

compile does not trigger a per-file format... I'm sure I had this working.

It currently lives inside the performance test plugin but there is nothing specific to performance tests in this task.

Looking at line

I would have thought that we would probably default to an all rights reserved license, allowing any project maintainer to easily amend to a more permissive license. (IANAL), but I would imagine that once a piece of source code is issued with a permissive license, then that license would be applied forever (it's not possible to remove the permissions granted by that license).

I'm all for open software, but it should be a conscious choice by the owner/maintainer of the software in question.

In CakeStandardsPlugin, this setting is questionable:

sys.env
.get("CI")
.fold(Seq.empty[String])(_ => Seq("-Xfatal-warnings"))

i.e. failing a CI build for compiler warnings that successfully build locally is not practicle in my opinion.

sbt-cake shouldn't depend on Gatling, ...

It's not something that should be imposed on the users as their project might not even use Gatling.
But it turns out that Gatling is needed by the CakeTestRunnerPlugin so we should make things more modular for a better user experience.

(Same thing goes for docker ...)

0.6.6 seems to have introduced a custom cache

@pjrt ^^^

When a publish fails due to a dirty git repo, we currently have little indication as to what was causing the repo to be dirty.

We need to add the output to the git status --porcelain command to the error output of publishing.