Code Monkey home page Code Monkey logo

cake.issues.msbuild's Introduction

cake.issues.msbuild's People

Contributors

brianfeucht avatar cho-trackman avatar dependabot-preview[bot] avatar dependabot-support avatar dependabot[bot] avatar eoehen avatar gep13 avatar jokay avatar kirillosenkov avatar martinegli avatar pascalberger avatar renovate[bot] avatar speeedy01 avatar t-johnson avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar

cake.issues.msbuild's Issues

Support MsBuild new location

MSBuild
The MSBuild toolset version has been changed from 15.0 to Current. MSBuild.exe is now in %VSINSTALLDIR%\MSBuild\Current\Bin\MSBuild.exe.
MSBuild (and Visual Studio) now targets .NET Framework 4.7.2. If you wish to use new MSBuild API features, your assembly must also upgrade, but existing code will continue to work.

Switch to recipe.cake file

This provides some immediate information that a repository is using
Cake.Recipe, and it is a convention now followed by a number of other
repositories.

Recommended changes resulting from automated audit

We performed an automated audit of your Cake addin and found that it does not follow all the best practices.

We encourage you to make the following modifications:

  • You are currently referencing Cake.Core 0.28.0. Please upgrade to 0.33.0
  • The nuget package for your addin should use the cake-contrib icon. Specifically, your addin's .csproj should have a line like this: <PackageIconUrl>https://cdn.jsdelivr.net/gh/cake-contrib/graphics/png/cake-contrib-medium.png</PackageIconUrl>.

Apologies if this is already being worked on, or if there are existing open issues, this issue was created based on what is currently published for this package on NuGet.

This issue was created by a tool: Cake.AddinDiscoverer version 3.12.1

MSBuild log generated by StyleCop throws ArgumentOutOfRangeException

The following Xml MSBuild log causes an System.ArgumentOutOfRangeException : startIndex cannot be larger than length of string.

<?xml version="1.0" encoding="utf-8"?>
<build started="3/11/2019 22:29:45">
  <warning code="SA1633" file="File.cs" line="1" column="1" started="3/11/2019 22:29:59"><![CDATA[The file header is missing or not located at the top of the file.]]></warning>
</build>

Support warnings without code attribute

Hi,

Although MSBuild XML log contains over 1000+ warnings

  <warnings>1033</warnings>
  <errors>0</errors>
  <starttime>5/19/2018 10:15:28 AM</starttime>
  <endtime>5/19/2018 10:15:54 AM</endtime>
  <timeelapsed>00:00:25.5523060</timeelapsed>

which contains both StyleCop warnings and Code Analysis warnings, only 2 issues are reported by:

    var issuesSettings = MsBuildIssuesSettings.FromFilePath(msBuildLogFile, MsBuildXmlFileLoggerFormat);
    var issues = ReadIssues(MsBuildIssues(issuesSettings), Environment.CurrentDirectory);
    Information(issues.Count());

Which are neither CA or SA warnings.

Is there maybe some parameter that I'm missing?

I can provide the XML log, but I'd rather not upload it on a public location.

Thank you,
Cosmin

DotNetCore[Build|Publish] Support

In my Build script I'm attempting to do this to generate the build output for the Issue tool.

DotNetCorePublish(".", new DotNetCorePublishSettings
        {
            Configuration = configuration,
            NoRestore = true,
            MSBuildSettings = new DotNetCoreMSBuildSettings()
                .WithLogger(
                    Context.Tools.Resolve("MSBuild.ExtensionPack.Loggers.dll").FullPath,
                    "XmlFileLogger",
                    $"logfile=\"{msBuildLogFile}\";verbosity=Detailed;encoding=UTF-8"
                )
        });

This does not work as the MSBuild.ExtensionPack.Loggers.dll doesn't work in the dotnet core msbuild Per dotnet/msbuild#2111.

Is there a work around? I see #38 which might also work but doesn't seem to be an active case.

Recommended changes resulting from automated audit

We performed an automated audit of your Cake addin and found that it does not follow all the best practices.

We encourage you to make the following modifications:

  • You are currently referencing Cake.Core 0.26.0. Please upgrade to 0.28.0
  • The Cake.Core reference should be private. Specifically, your addin's .csproj should have a line similar to this: <PackageReference Include="Cake.Core" Version="0.28.0" PrivateAssets="All" />

Build against Cake 0.26.0

Cake 0.26.0 introduced breaking changes. To support Cake versions >= 0.26.0 this addin should be built against Cake 0.26.0

Add support for binlog version 9 file format

It would be great to have support for the latest binlog version 9 that gets outputted when using /binarylogger together with dotnet build (Assuming the latest version of MSBuild as well).

I am guessing this support would be included with the update with the PR #158.

Parse errors from log files

Parse errors from log files in MsBuildBinaryLogFileFormat and MsBuildXmlFileLoggerFormat

  • Support parsing of errors in MsBuildXmlFileLoggerFormat (GH-199)
  • Support parsing of errors in MsBuildBinaryLogFileFormat (GH-205)
  • Update feature documentation (GH-204)

Improve log output while parsing log files

I spend a long time debugging why Issues didn't have the correct paths set. It turns out that using a logger where the verbosity is set to Quiet does not contain the <project... element that contains the project path. The issue is that XmlFileLoggerLogFileFormat is silent about it and you have to debug a lot to discover it.

I suggest adding a disclaimer somewhere or make XmlFileLoggerLogFileFormat throw. What do you think?

Allow to retrieve issue provider type name without context

There's currently a Cake alias property for retrieving the name of the issue provider type (MsBuildIssuesProviderTypeName). This requires a Cake context and there might be situations where no context is available. There should be a way to retrieve the issue provider type name without requiring a context.

Recommended changes resulting from automated audit

We performed an automated audit of your Cake addin and found that it does not follow all the best practices.

We encourage you to make the following modifications:

  • The Cake.Core reference should be private. Specifically, your addin's .csproj should have a line similar to this: <PackageReference Include="Cake.Core" Version="0.28.0" PrivateAssets="All" />

Apologies if this is already being worked on, or if there are existing open issues, this issue was created based on what is currently published for this package on NuGet.org and in the project on github.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.