c-hive / fresh-bot Goto Github PK

hi, thanks your fresh-bot tools, but when I configured it, it reported an error:

TypeError: Cannot destructure property `login` of 'undefined' or 'null'.

This is my fresh-bot.yml:

name: Bump stale issues


on:
  schedule:
    # Run every minute
    - cron: '* * * * *'
  push:
    branches: [ master ]


jobs:
  fresh-bot:
    runs-on: ubuntu-latest


    steps:
      - name: Bump stale issues
        uses: c-hive/fresh-bot@v1
        with:
          GITHUB_TOKEN: ${{ secrets.FRESH_BOT_TOKEN }} # Needs `repo` scope

The FRESH_BOT_TOKEN() is set in https://github.com/Alanwang2015/Actions-Fresh-bot , and it's value is copied from global Personal access token, what did I wrong?

https://github.com/c-hive/fresh-bot/runs/889751606
https://github.com/c-hive/fresh-bot/runs/827457666

Comment: #14 (comment). Let's use the type property instead of regexes to detect comments from bots.

link

I'd automate the major version binding, mostly just for the sake of convenience.

Resources:

• article: https://michaelheap.com/semantic-versioning-for-github-actions/
• action: https://github.com/marketplace/actions/actions-tagger

This is consistently failing as defined in https://github.com/GiovanH/actions/blob/main/.github/workflows/fresh-bot.yml, using the master branch. (It also fails with the v1 tag.)

Found stale bot comment https://api.github.com/repos/julmot/mark.js/issues/comments/1232336903 on issue https://api.github.com/repos/julmot/mark.js/issues/479
Error: TypeError: Cannot read property 'groups' of null

It looks like it's silently failing to fetch the commentParams object here:

Use periodic actions to automatically trigger notification checks

• would this work in forks?
• need to setup client id and secret is secrets (would hopefully work automatically like this, but not sure)

The motivation to create an app was that it would be nice if the comment could be written by an app instead of the specific users.

AFAIR there were some issues with this (don't take these as 100% accurate, just what I recall from a year ago). "Regular" apps have to be installed on a repo and can comment on that specific repo only. OAuth apps would have access to users' notifications and could even post but require a running deployment that keeps track of oauth tokens (there could still be an issue with public vs private repos).

Finally looking at where things are headed it seems reasonable to move towards Actions instead. Therefore see #5

The initial MVP was planned to be a GitHub app using Probot and exposing an endpoint to trigger the check. Actions allow us to greatly simplify this.

MVP flow:

• create a personal repo for running periodic actions
• set personal access token as a secret for the repo
• run this action periodically
• this action uses the personal access token to fetch notifications and checks for comments by stale bots (as it already does)
• it replies automatically when there isn't a follow-up reply yet

Existing code can definitely be refactored. Repo must be set up based on https://github.com/c-hive/js-boilerplate.

https://github.com/c-hive/gha-remove-artifacts is a good base for stealing some code ;)

Need to make sure personal access token is enough to read notifications & write comments.

For the old app-style approach see: #6 and master@55e8b86dbcbc7223bc4cdb1511657a446797d52d