bzzt / bigtable Goto Github PK

If you plan on implementing retries, here are a few things to watch out for:

• For ReadRows make sure to track both the last merged row key and the last_scanned_row_key. So that you can skip over any filtered out rows on stream resumption
• There is a gotcha with ServerStreaming RPCs, where they can send all of their data but return an error status code. This is particularly dangerous with ReadRows, where if you aren't careful the resumption request can end up being empty triggering a full table scan.
• Try to avoid using serverside timestamps. They prevent mutations from being idempotent

In terms of default timeouts and retry counts, I would recommend to track gapic configs.

Unfortunately, since I'm not familiar with elixir, I don't have anything more specific. If you have any further questions, feel free to ping me.

Originally posted by @igorbernstein2 in #8 (comment)

The "typed" functionality currently in this repo should be extracted to another project. This functionality adds the ability to create Bigtable Schemas that are used for creating mutations and parsing results in a very opinionated manner. In the future I also plan to implement BigQuery schema definition file and SQL view generation based on the opinionated schemas.

Currently only the data gRPC API is usable with the library. The admin client needs to also be added, but can probably wait until after 1.0

Is your feature request related to a problem? Please describe.
Hi,
I've been working on a new java client for bigtable and ran across this repo. I would like to thank you creating this client. I think it's a great addition to the Bigtable ecosystem. While poking around I noticed that there some edge cases that weren't covered in this client's ReadRows implementation. For example, it doesn't appear like the reset flag is respected.

Describe the solution you'd like
On the Cloud Bigtable team we created a json file to help test ReadRow chunk parsing and I wanted to let you know of its existence:
https://github.com/googleapis/google-cloud-java/blob/master/google-cloud-clients/google-cloud-bigtable/src/test/resources/com/google/cloud/bigtable/data/v2/stub/readrows/read-rows-acceptance-test.json
Each test case has a list of chunks and the expected Row results.

Additional context
Here are a couple of links of other clients using the file:

• java
• golang
• python

Thanks again for publishing this client!

All public functions should either have type specs added or their existing ones checked

ReadModifyWriteRules and the ReadModifyWrite operation need to be implemented before 1.0.0 release.