Code Monkey home page Code Monkey logo

loose's Introduction

README

Let's get Loose!

loose's People

Contributors

bwnance avatar

Stargazers

Esther avatar  avatar

Watchers

James Cloos avatar

loose's Issues

PM Review #3: Messages & Channels

Brandon,

Great work on you next two MVPs so far - they're nearly there. Some comments:

  • When I make a new account and attempt to join one channel, I am automatically made a member of every channel (not just the one I tried to join). If I log out and log back in, then I am only a member of the channels I intentionally joined.
  • If a channel has more messages than fit on screen, new messages are animated on submit (they "slide" into position, rather than just appearing as they did before). Slack does not appear to animate new messages.
  • The text in the lefthand channels list could be slightly larger
  • Users should be able to set a topic for channels to which they belong
  • Users should have the ability to edit and delete their own messages
  • Users should have the ability to edit and delete channels they have created

Let me know if you have any questions!

PM Review #1: Design Documents

Brandon,

Good start on your design documents. Some initial comments on each:

MVP List

  • Needs to be completed

Schema

  • All tables should feature timestamps
  • It doesn't look like your schema takes direct messages into consideration. Please refactor accordingly, as DMs is a required feature.
  • I would suggest you use non-integer data to indicate permission levels. Semantic strings will significantly improve the readability of both the data itself and the rest of your code.
  • Slack uses binary permissions for channels. Ternary permissions are used only for workspaces. Please update accordingly.

Sample State

  • Consider simplifying your frontend state to make it easier for you to handle within a given component. For example: could channel_permissions be split into three arrays, such as admin_channel_ids, mod_channel_ids, etc.?
  • Incorporate additional updates warranted by schema changes.

Backend Routes

  • This page has a header of "Frontend Routes" - please change.
  • Add a route to create a new user
  • Your POST /api/channels/:channel_id/messages/messages/ route has an extra /messages - please remove
  • Do you need a route to fetch one specific message? When would that be needed?
  • Similarly, do you need a route to get a specific channel? Why?
  • Same as above re: GET /api/workspaces - this is probably unnecessary
  • You will need API endpoints to add users to channels/workspaces, and to handle DMs. Please add these.

Frontend Routes
Looks good!

PM Review #2: User Auth

Brandon,

Great start on your fullstack! Some comments at this stage:

  1. Your CSS styling is coming along, but still needs work:
  • The Loose splash page is relatively blank, while Slack incorporates a background GIF and a nav bar. You should do the same.
  • I like your change of color palette, but the spacing/structure of elements on the page should look identical. Pull up your app and Slack side-by-side to compare - and aim for pixel perfect recreation of the original!

Great job handling errors so far - these look great. Please aim to address the above by Monday, along with as much work as can be done on live messaging and channels. This will put you in a great position to handle permission and workspaces come next week. Let me know if you have any questions!

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.