Code Monkey home page Code Monkey logo

burgerswap-core's People

Contributors

burgerswap-org avatar tercel avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

burgerswap-core's Issues

Missing files

Apparently there are files missing from this project.

Security Report: Subdomain Takeover of https://s3.burgerswap.org/ pointing to AWS S3

Hi BurgerSwap Security Team,

I was told by the internal team to report this to you

Description

Recently I found this issue in one of your website *burgerswap.org which suffer from possible Subdomain takeover attack.

Please take a look at this:

https://s3.burgerswap.org/

I temporarily takeover the subdomain and hosted a sample website for POC. Please take a look

https://s3.burgerswap.org/home.html

POC1

Everytime you navigate to the subdomain, you will be pointed to the website that I now already owned.

This vulnerability can reflect to an email leak from your company, due to the situation that the attacker can receive email transactions from the company and clients.

Please refer to this report for further information; https://hackerone.com/reports/388622 https://hackerone.com/reports/325336

Impact

I was able to hijack the domain s3.burgerswap.org because an outdated DNS entry pointed to Gitbook. I created a resource in that web hosting and was able to host my own content accessible via your domain. HTML files located on this domain are able to use JavaScript to access globally-scoped non-HTTPOnly cookies. For example, a cookie used to authenticate against topsecret.burgerswap.org is scoped to *burgerswap.org, so a page on my hijacked domain can steal it.

This vulnerability is rated as severe due to the increased impact that can be escalated to a high severity threat and boils down to the registration of a domain by somebody else (with bad intentions) in order to gain control over one or more (sub)domains. This presents an interesting attack vector, which can even lead to several high severity risks, like this authentication bypass explained in a bug bounty report https://hackerone.com/reports/172137 by @ArneSwinnen.

Risk Breakdown

Risk: High Difficulty to Exploit: Easy Complexity: Easy Weakness Categories: Deployment Misconfiguration/Stored XSS/Authentication Bypass (CWE: 16) CVSS2 Score: 9.3 (AV:N/AC:M/Au:S/C:C/I:C/A:N) Reference: https://0xpatrik.com/subdomain-takeover/

Remediations

Check your DNS-configuration for subdomains pointing to services, not in use
Set up your external service so it fully listens to your wildcard DNS.
Our advice is to keep your DNS entries constantly vetted and restricted.
4.Preventing subdomain takeovers is a matter of order of operations in lifecycle management for virtual hosts and DNS. Depending on the size of the organization, this may require communication and coordination across multiple departments, which can only increase the likelihood for a vulnerable misconfiguration. 5. Create an inventory of all of your organization’s domains and their hosting providers, and update it as things change, to ensure that nothing is left dangling.

Thank you

Contacts

Hi there i can't found the proper Router deployed Contract Address may you point me to the correct one?

thanks

UI not working

the UI on burgerswap.org is not reacting (specifically the buttons for choosing tokens). Tried on Firefox, Chrome and Brave, same problem on each. Also tried on two different machines.

Issue Computing Reward for Proposer (Governance) DemaxGovernance.sol

Basically, the proposer should get the initial proposal cost that he spent + some rewards in case the proposal is accepted
Issue (Doc on the official site)

The issue seems to be here:

  • function getReward(address _ballot) public view returns (unit) / After createConfigBallot has been initiated
  • File: burgerswap-org/burgerswap-core/blob/master/contracts/DemaxGovernance.sol

In reality, the proposer can lose some of his token, so the calculation is not good.
I send a Google form with the details. I hope you can find it!

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.