bulton-fr / teso_libdragonworldevent Goto Github PK

Great add-on! However, in Auridon the North and South dolmens are the wrong way round (i.e. when the add-on shows the North as active, the South will be up).

I realise it's not a big deal, but it bugged me and reinstalling didn't fix it. I ended up editing the Auridon section of the Dolmen POI file from:
[1] = 771, --Iluvamir Dolmen
[2] = 772, --Calambar Dolmen
[3] = 773, --Vafe Dolmen

to:
[1] = 773, --Vafe Dolmen
[2] = 772, --Calambar Dolmen
[3] = 771, --Iluvamir Dolmen

https://github.com/esoui/esoui/blob/pts6.3/ESOUIDocumentation.txt#L6155

h5. WorldEventLocationContext

• WORLD_EVENT_LOCATION_CONTEXT_NONE
• WORLD_EVENT_LOCATION_CONTEXT_POINT_OF_INTEREST
• WORLD_EVENT_LOCATION_CONTEXT_UNIT

https://github.com/esoui/esoui/blob/pts6.3/ESOUIDocumentation.txt#L8463

MAP_PIN_TYPE_WORLD_EVENT_POI_ACTIVE

https://github.com/esoui/esoui/blob/pts6.3/ESOUIDocumentation.txt#L15597

• GetWorldEventLocationContext(integer worldEventInstanceId)
  ** Returns: [WorldEventLocationContext|#WorldEventLocationContext] locationContext

https://github.com/esoui/esoui/blob/pts6.3/ESOUIDocumentation.txt#L15609

• GetWorldEventPOIInfo(integer worldEventInstanceId)
  ** Returns: luaindex zoneIndex, luaindex poiIndex

• GetPOIWorldEventInstanceId(luaindex zoneIndex, luaindex poiIndex)
  ** Returns: integer worldEventInstanceId

Use zoneIdx is now the old zoneIdx + 1

Ideally we need to find a solution without use zoneIdx, I don't want to update it at each module which add new map.

In preparation of Greymoor, and the likely arrival of new events types, we will need to prepare the code for that.

Try with new functions IsUnitFalling and IsUnitInAir

Added in V100030 (maj 25) : https://forums.elderscrollsonline.com/en/discussion/511028/update-25-api-patch-notes-change-log-pts

Libraries' .txt (manifest) file should/must always contain the
## AddOnVersion: <unsigned integer>
e.g. ## AddOnVersion: 211
tag pelase so that the ingame addon manager is able to load ONLY hte newest (highest) version!
Also other addons depending on your lib are able to use ## DependsOn: LibWorldEvents=>211 then properly to make the addons NOT load if old versions are provided only, or the version is missing in total in the instaleld libraries's txt file.
This assures that addons will work properly without having the need to check for existing function names or controls ~= nil in their code.

Thanks for adding this to your txt file of this library.

Info about this can be found here;
[url]https://wiki.esoui.com/Libraries#.23.23_AddOnVersion:_.3Csigned_integer.3E[/url]

Many POI Type "class" copy/paste the same code, like the function generateList or obtainList.
So it's can be a good idea to have an "abstract class" which define these function (and also shared properties) to avoid copy/paste, and also to keep on poi type "classes" only the code dedicated to the poi type.

Also maybe move all the poi type "classes" to a subfolder "types".
With years and the add of new world event types, I'm worry about the mix of files will increase and the folder which will become unreadable