Input in basic starter loses focus after loading script about qwik HOT 5 CLOSED

I looked into it. The issue with this line: https://github.com/BuilderIO/qwik/blob/e4493e57f1e5bdad89b071ab0c824a9efd367e93/starters/apps/starter/src/my-app.tsx#L25

Notice that there is text + {' '}. Thes creates two text nodes. When these text nodes get serialized into HTML they get merged into one. Once the reconciliation algorithm runs the result is that the JSX does not match the HTML and results in the <input being destroyed and re-created. This results in a loss of focus.

I think the fix is to update the reconciliation algorithm to see when there is extra text and auto-create text nodes out of it. Should be a straightforward fix.

from qwik.

Fixed by 7fadd18

from qwik.

I noticed this issue too

from qwik.

Tried a few different scenarios and looked at the flash of updates in dev tools...

Original example

Put the text in a paragraph (focus issue goes away)

Placing the input as a lone sibling and things work as expected?

Any ideas? 🤔

from qwik.

I found that the replaceNode function causes this by removing the input element before putting the mounted input. So perhaps it should keep focus after replacing. You'll see this by setting a break point for when the initial input element is removed.

from qwik.