bufferapp / buffer Goto Github PK

Hey @jwinternheimer! I noticed your discussion with @mallen5311 about the BuffeR package we still had in the bufferapp organization. Since we weren't using that one and your repo is the active one, I went ahead and deleted the old bufferapp/buffeR repo.

I was curious how you felt about perhaps transferring ownership of this repo to the bufferapp org, just to make reduce the chance of confusion?

Heya @jwinternheimer! I've noticed the forecaster is failing and after checking the logs I've noticed is not reading the environment variables properly.

The error might be caused by this line: https://github.com/jwinternheimer/buffer/blob/master/R/write_to_redshift.R#L39

These are the logs:

Enter your AWS access key: 
Enter your AWS secret access key: 
Error in Sys.setenv(AWS_SECRET_ACCESS_KEY = secret_keu) : 
  object 'secret_keu' not found
Calls: main -> <Anonymous> -> Sys.setenv
Execution halted

Let me know if I can share anything else!

Heya @jwinternheimer! While setting up a service that uses this package I spotted that for the package to work, it requires a few environmental variables.

For example, the mrr-forecaster is using the Redshift variables but doesn't require the Looker or AWS ones. When running the script without the Looker or AWS environment keys it's failing.

Is there a way to make this dependencies optional? Would love to hear how difficult that would be since having these variables as optional would simplify the setup in production.