The bttv from bttv-android

Remove "Enable" prefix for settings items

Streams sometimes stutter

I just noticed performance issues with the mod, that don't happen in the official version.
It feels like some frames are dropped, maybe the mod does too much on the UI thread?
This is new and probably caused by an base update.

Publish monkey patches

Base update detected (february 23, 2021)

The watchdog detected a new update was pushed on february 23, 2021 (last record was on february 10, 2021).
Google Play: https://play.google.com/store/apps/details?id=tv.twitch.android.app&hl=en&gl=us

Base update detected (april 29, 2021)

The watchdog detected a new update was pushed on april 29, 2021 (last record was on april 19, 2021).
Google Play: https://play.google.com/store/apps/details?id=tv.twitch.android.app&hl=en&gl=us
cc: @bttv-android/developers

Ensure build/build workflow always runs after docker/build is done

Reduces margin of human error.

Update to 10.1.0

Full genmonke script

Automate instructions in readme.

Remove usage of bttv_settings string to make updates easier

Looks like ids are not stable in updates, which means new strings / resources can override the bttv_settings id. This will cause additional maintenance. The "BTTV" string could not be translated anyway.

Enforce annotation to monkey patches

Merging updates is still a bit if-y.
Each monkey patch should be annotated (using a comment) with information like:

What does this patch do?
Which registers does it use?
Which assumptions does it make on registers (types)?
Does it change any registers or are all changes reverted?

This should be somewhat formalized so a linter could automatically check for correctness.

Base update detected (may 4, 2021)

The watchdog detected a new update was pushed on may 4, 2021 (last record was on april 29, 2021).
Google Play: https://play.google.com/store/apps/details?id=tv.twitch.android.app&hl=en&gl=us
cc: @bttv-android/developers

Updater

Check for updates either periodically or at every start.

Typo: ChatMessageDeligateWrapper instead of ChatMessageDelegateWrapper

Docker for build

I think most of the tools can be packed into a docker image. This would make the build process much easier for newcomers.

Settings Activity

Add a new item to the Settings Activity for BTTV-android
Checkable:

BetterTTV Emotes
BetterTTV Gif Emotes
FrankerFaceZ Emotes

Auto-Claim Bonus Channel Points

Automatically claim bonus channel points

Base update detected (april 19, 2021)

The watchdog detected a new update was pushed on april 19, 2021 (last record was on april 8, 2021).
Google Play: https://play.google.com/store/apps/details?id=tv.twitch.android.app&hl=en&gl=us
cc: @bttv-android/developers

Handle twitch.tv links etc.

Right now only the official Twitch App is opened. :/

Base update detected (april 8, 2021)

The watchdog detected a new update was pushed on april 8, 2021 (last record was on march 25, 2021).
Google Play: https://play.google.com/store/apps/details?id=tv.twitch.android.app&hl=en&gl=us
cc: @bttv-android/developers

Handle onTap of emotes in chat

Right now it shows an error panel.
Show some information about the emote or stop the panel from showing up.

Anon Chat

Join chat anonymously without appearing in the userlist

Remove trailing whitespace in monke.patch

Right now git issues the following warnings:

../monke.patch:36: trailing whitespace.
        <provider 
../monke.patch:2081: trailing whitespace.
    
../monke.patch:2126: trailing whitespace.
    
../monke.patch:2149: trailing whitespace.

Let's fix that.

Replace update strings

Remove some log statements

Some pieces of debugging code still seems to spam the logcat, remove it.

Auto add .gitignore

Monkey patches increase apk file by 29%

The latest base requires 84MB on disk,
the mod however is 125 MB in size.

Why?

Add linter

I'm tired of this hacky-ass looking code.

I just have no Idea about the Java/Android ecosystem.

Move (binary) resources outside of monke.patch

The png files bloat up the monke.patch file. We can move it to the mod res dir and let the replacement happen in buildsource.

Replace R.id.* usage with getIdentifier()

If the resource id change this file needs to be updated: https://github.com/bttv-android/bttv/blob/master/mod/twitch/src/main/java/tv/twitch/android/app/R.java

it is used here:

bttv/mod/app/src/main/java/bttv/UpdaterActivity.java

Line 47 in f8a3bf4

TextView titleView = (TextView) findViewById(R.id.bttv_updater_activity_title);

here:

bttv/mod/app/src/main/java/bttv/UpdaterActivity.java

Line 50 in f8a3bf4

TextView bodyView = (TextView) findViewById(R.id.bttv_updater_activity_body);

and here:

bttv/mod/app/src/main/java/bttv/UpdaterActivity.java

Line 53 in f8a3bf4

ProgressBar bar = (ProgressBar) findViewById(R.id.bttv_updater_activity_pb);

It should be replaced with Context.getResources().getIdentifier()

Base update detected (june 1, 2021)

The watchdog detected a new update was pushed on june 1, 2021 (last record was on may 17, 2021).
Google Play: https://play.google.com/store/apps/details?id=tv.twitch.android.app&hl=en&gl=us
cc: @bttv-android/developers

Base update detected (march 22, 2021)

The watchdog detected a new update was pushed on march 22, 2021 (last record was on march 15, 2021).
Google Play: https://play.google.com/store/apps/details?id=tv.twitch.android.app&hl=en&gl=us

cc: @bttv-android/developers

Organize bttv package

The only reason why it is not working right now is because I was to lazy to write a proper script.

Set up gradle/android studio project for source

This would remove the need of mocking android APIs, would allow the inclusion of maven dependencies and could make the layout designer easier to use.

Base update detected (may 17, 2021)

The watchdog detected a new update was pushed on may 17, 2021 (last record was on may 4, 2021).
Google Play: https://play.google.com/store/apps/details?id=tv.twitch.android.app&hl=en&gl=us
cc: @bttv-android/developers