bryx-inc / geojson.swift Goto Github PK

In GeoJSONMultiPolygon.swift line 18 casts featureArrays as [AnyObject]. The next line where FeatureType.init is called it passes in a dictionary of ["coordinates": $0] which is [String, AnyObject]. This results in the init call of GeoJSONFeature being called rather than the init from GeoJSONPolygon since the dictionary for GeoJSONPolygon requires [String: Any]. The end result is that GeoJSONFeature init returns nil. The fix is to line 18 changing AnyObject to Any.

GeoJSON allows for properties in a subdictionary. We should support that, or provide a way for subclasses to access that.

Is there a carthage version of this lib or can a carthage install option be added?
Thank You for this library.

/Pod/Classes/GeoJSONFeature.swift:23:25: Contextual type 'Any' cannot be used with dictionary literal

https://github.com/bryx-inc/GeoJSON.swift/blob/master/Pod/Classes/GeoJSONFeatureCollection.swift#L19
The type GeoJSONFeatureCollection is currently representing the entity https://tools.ietf.org/html/rfc7946#section-3.1.8 GeometryCollection as a FeatureCollection,
when FeatureCollection is defined separately as https://tools.ietf.org/html/rfc7946#section-3.3

Recommendations: Represent GeometryCollection and FeatureCollection as first class members of the EntityMap (typeMap) and create GeoJSONGeometryCollection to represent the GeometryCollection entity of the specification.

without FeatureCollection doesn't make much sense at all