bryanxu / leveldb-go Goto Github PK

Is this project alive? I saw some contributors changes but nothing from the 
original (c++) authors recently. Is this project following the c++ leveldb 
development?

What steps will reproduce the problem?
1. follow directions on front page ("go get 
code.google.com/p/leveldb-go/leveldb")

What is the expected output? What do you see instead?

Expected: working install of leveldb-go
Actual: 
# code.google.com/p/leveldb-go/leveldb/memdb
../../../tools/go/src/code.google.com/p/leveldb-go/leveldb/memdb/memdb.go:90: 
syntax error: unexpected :, expecting ]
# code.google.com/p/leveldb-go/leveldb/table
../../../tools/go/src/code.google.com/p/leveldb-go/leveldb/table/reader.go:135: 
syntax error: unexpected :, expecting ]
../../../tools/go/src/code.google.com/p/leveldb-go/leveldb/table/reader.go:143: 
syntax error: unexpected :, expecting ]


What version of the product are you using? On what operating system?

go version go1.1.2 linux/arm

Please provide any additional information below.

It would be nice if you could update the front page to say what version of go 
is required. I'm having a hard time finding any releases newer than 1.1.2, or 
any official information on which release supports this new [::] syntax.

I've been happily using the memdb implementation of db.DB and was wondering if 
there's a persistent implementation of db.DB in the works?

Very very importation create documentation for guideline user.

To reproduce:

1. leveldb.db.Open a directory that doesn't exist
2. You will get the following error: "DB Error: leveldb: could not open CURRENT 
file for DB <your directory>: open <your directory>/CURRENT: no such file or 
directory"

What is the expected output? What do you see instead?


What version of the product are you using? On what operating system?
The current version (I just did a `go get`) on Ubuntu 12.10

implements would be great BSON[1][2], mongodb[3] uses BSON

[1] http://bsonspec.org/#/implementation
[2] https://github.com/mikejs/gomongo
[3] http://www.mongodb.org/

Add unit test is very very necessary.

What steps will reproduce the problem?
1. log.SetOutput(io.MultiWriter(f, os.Stdout))
2. log some stuff, shows up in file f
3. open database: levigo.Open(dbName, dbOpts)
4.) log some more stuff, but now it doesn't show up in file f

What is the expected output? What do you see instead?
logging should continue after the db is opened, but it doesn't.
There is a workaround, where you can call log.SetOutput() again just after 
leveldb.Open() and logging resumes.

What version of the product are you using? On what operating system?
go 1.2.1 on amd64 ubuntu 14.04, with leveldb from github on 04/28/14 (sorry, 
commit # missing as the files were copied to a new repo)

The installation instructions on the front page, 
http://code.google.com/p/leveldb-go/, refer to the obsolete goinstall utility.

I built 8c09ded0e4ad and attempting to create/open a persistent LevelDB using 
leveled.Open(dirname, nil) fails with an error message complaining that file 
locking is not implemented in solaris. The issue is the build constraints in 
leveldb/db/file_lock_unix.go and leveldb/db/file_lock_generic.go do not include 
Solaris/Illumos (which is supported as of Go 1.3).

The fix is:

diff -r 8c09ded0e4ad leveldb/db/file_lock_generic.go
--- a/leveldb/db/file_lock_generic.go   Thu Sep 25 10:17:15 2014 +1000
+++ b/leveldb/db/file_lock_generic.go   Fri Oct 10 20:02:50 2014 -0700
@@ -2,7 +2,7 @@
 // Use of this source code is governed by a BSD-style
 // license that can be found in the LICENSE file.

-// +build !darwin,!dragonfly,!freebsd,!linux,!netbsd,!openbsd,!windows
+// +build !darwin,!dragonfly,!freebsd,!linux,!netbsd,!openbsd,!windows,!solaris

 package db

diff -r 8c09ded0e4ad leveldb/db/file_lock_unix.go
--- a/leveldb/db/file_lock_unix.go      Thu Sep 25 10:17:15 2014 +1000
+++ b/leveldb/db/file_lock_unix.go      Fri Oct 10 20:02:50 2014 -0700
@@ -2,7 +2,7 @@
 // Use of this source code is governed by a BSD-style
 // license that can be found in the LICENSE file.

-// +build darwin dragonfly freebsd linux netbsd openbsd
+// +build darwin dragonfly freebsd linux netbsd openbsd solaris

 package db

package main

import (
    "code.google.com/p/leveldb-go/leveldb/db"
    "code.google.com/p/leveldb-go/leveldb/table"
    "runtime"
)


const (
    DBFILE = "/tmp/leveldb2.db"
)

var DBFS = db.DefaultFileSystem 


func main() {
    Connection, e := DBFS.Create(DBFILE); Check(e)
    w := table.NewWriter(Connection,nil)
    defer w.Close()

    e = w.Set([]byte("1"), []byte("red"),nil); Check(e)
    e = w.Set([]byte("2"), []byte("yellow"),nil); Check(e)
    e = w.Set([]byte("3"), []byte("red"),nil); Check(e) 
    w.Close()
    w = nil
    Connection, e = DBFS.Open(DBFILE); Check(e)
    w = table.NewWriter(Connection,nil)
    defer w.Close() 
    e = w.Set([]byte("4"), []byte("red"),nil); Check(e)
    e = w.Set([]byte("5"), []byte("yellow"),nil); Check(e)
    e = w.Set([]byte("6"), []byte("red"),nil); Check(e)
    w.Close()
    read()
}

func read() {
    Connection, e := DBFS.Open(DBFILE); Check(e)
    b := []byte("0")
    r := table.NewReader(Connection,nil)
    iter := r.Find(b, nil)
    for iter.Next() {
        p(iter.Value(), nil)
    }
    r.Close()
}

func Check(e error) {
    if e != nil {
        _, file, line, _ := runtime.Caller(0)
        println(line, " File: ", file, "Error: ", e)
    }
}

func p(r []byte, e error) {
    if e != nil {
        println("Error: ", e)
    }
    println(string(r))      
}

What steps will reproduce the problem?
1. go get code.google.com/p/leveldb-go/leveldb/table

What is the expected output? What do you see instead?

A clean installation is expected, instead an error occurs.

Fix:

Change references in leveldb/table/reader.go and leveldb/table/writer.go from 
"code.google.com/p/snappy-go/snappy" to "github.com/golang/snappy/snappy".

I do not know yet the project is still in development :)

What steps will reproduce the problem?
1. go get code.google.com/p/leveldb-go/leveldb/table

What is the expected output? What do you see instead?

A clean installation is expected, instead an error occurs.

Fix:

Change references in leveldb/table/reader.go and leveldb/table/writer.go from 
"code.google.com/p/snappy-go/snappy" to "github.com/golang/snappy/snappy".

Also, it would be great if issues were opened for what's remaining so others 
could pitch in. 

We'd really like to use this if it's close to the real thing. 

go version
go version devel +d58997478ec6 Mon Apr 08 00:09:35 2013 -0700 windows/386

go test code.google.com/p/leveldb-go/leveldb/memfs
--- FAIL: TestList (0.00 seconds)
        memfs_test.go:178: Create "/bar/baz": leveldb/memfs: no such directory
FAIL
FAIL    code.google.com/p/leveldb-go/leveldb/memfs      0.043s

panic: runtime error: assignment to entry in nil map

goroutine 1311 [running]:
runtime.panic(0x1a0fa0, 0x2dc2f3)
    /Users/crawshaw/go/src/pkg/runtime/panic.c:279 +0xf5
code.google.com/p/leveldb-go/leveldb.(*tableCache).findNode(0x2091a6080, 0x3f, 
0x0)
    /Users/crawshaw/gotools/src/code.google.com/p/leveldb-go/leveldb/table_cache.go:90 +0x14c
code.google.com/p/leveldb-go/leveldb.(*tableCache).find(0x2091a6080, 0x3f, 0x0, 
0x0, 0x0, 0x0, 0x0, 0x0, 0x0)
    /Users/crawshaw/gotools/src/code.google.com/p/leveldb-go/leveldb/table_cache.go:41 +0x74
code.google.com/p/leveldb-go/leveldb.compactionIterator(0x2091a6080, 
0x2208345698, 0x20847bec0, 0x20c68b6e0, 0x0, 0x0, 0x0, 0x0)
    /Users/crawshaw/gotools/src/code.google.com/p/leveldb-go/leveldb/compaction.go:414 +0x59f
code.google.com/p/leveldb-go/leveldb.(*DB).compactDiskTables(0x2091a6000, 
0x20c68b6e0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0)
    /Users/crawshaw/gotools/src/code.google.com/p/leveldb-go/leveldb/compaction.go:272 +0x222
code.google.com/p/leveldb-go/leveldb.(*DB).compact1(0x2091a6000, 0x0, 0x0)
    /Users/crawshaw/gotools/src/code.google.com/p/leveldb-go/leveldb/compaction.go:210 +0x353
code.google.com/p/leveldb-go/leveldb.(*DB).compact(0x2091a6000)
    /Users/crawshaw/gotools/src/code.google.com/p/leveldb-go/leveldb/compaction.go:166 +0x78
created by code.google.com/p/leveldb-go/leveldb.(*DB).maybeScheduleCompaction
    /Users/crawshaw/gotools/src/code.google.com/p/leveldb-go/leveldb/compaction.go:159 +0x85

goroutine 16 [runnable]:
main.matchString(0x1c1110, 0x0, 0x1f5390, 0x24, 0x145301, 0x0, 0x0)
    code.google.com/p/leveldb-go/leveldb/_test/_testmain.go:80
testing.RunTests(0x231160, 0x2dc360, 0x19, 0x19, 0x150b01)
    /Users/crawshaw/go/src/pkg/testing/testing.go:480 +0x2c7
testing.Main(0x231160, 0x2dc360, 0x19, 0x19, 0x2e62a0, 0x0, 0x0, 0x2e62a0, 0x0, 
0x0)
    /Users/crawshaw/go/src/pkg/testing/testing.go:435 +0x87
main.main()
    code.google.com/p/leveldb-go/leveldb/_test/_testmain.go:95 +0x9c

goroutine 19 [finalizer wait]:
runtime.park(0x14490, 0x2df9c0, 0x2ded78)
    /Users/crawshaw/go/src/pkg/runtime/proc.c:1354 +0x89
runtime.parkunlock(0x2df9c0, 0x2ded78)
    /Users/crawshaw/go/src/pkg/runtime/proc.c:1370 +0x3b
runfinq()
    /Users/crawshaw/go/src/pkg/runtime/mgc0.c:2628 +0xcf
runtime.goexit()
    /Users/crawshaw/go/src/pkg/runtime/proc.c:1430

goroutine 591 [runnable]:
code.google.com/p/leveldb-go/leveldb.(*DB).compact(0x2083a9200)
    /Users/crawshaw/gotools/src/code.google.com/p/leveldb-go/leveldb/compaction.go:163
created by code.google.com/p/leveldb-go/leveldb.(*DB).maybeScheduleCompaction
    /Users/crawshaw/gotools/src/code.google.com/p/leveldb-go/leveldb/compaction.go:159 +0x85
FAIL    code.google.com/p/leveldb-go/leveldb    1.602s

Can be produced by running the attached stress test about ten times at tip:

go version devel +9eacb9c0d810 Thu Apr 24 12:24:22 2014 -0700 + darwin/amd64

What steps will reproduce the problem?
1. try to run leveldb-go on osx

What is the expected output? 

N/A

What do you see instead?

leveldb/db: file locking is not implemented on darwin/amd64

What version of the product are you using?

head (i think this is what 'go get' fetches)

On what operating system?

osx 10.7.4 (darwin)


It seems (based on my reading of the build flags in file_lock_generic.go) that 
any system that is is not linux and not amd64 gets the above message.

Is leveldb-go just untested on anything else, or is it known to not work? (I 
thought fcntl was supported on darwin -- no clue how *well* supported though).

thanks.

>What steps will reproduce the problem?
- Create new db
- Write big chunk of data (>32kb in my case)
- Close db
- Reopen db

>What is the expected output? What do you see instead?
leveldb: corrupt log file "/tmp/dontcorruptme/000003.log"

>Notes
db.WriteOptions{Sync: true} fixes the issue.