brugman / acf-agency-workflow Goto Github PK

HI, so after installing, when i activate the plugin, the default ACF menu item just disappears?

I debugged by changing to default theme and deactivating everything except ACF Pro and this plugin.

Firstly great plugin, thank you.

I have a scenario where fields are saved in parent theme, and the child theme just uses these fields. When changes are made, they are saved in parent theme.

Your plugin is exactly what i was looking for as i used custom fields in a custom plugin also. However whilst i can use Plugin and Child theme together, i cant get Plugin and Parent theme to work. Creating an acf-json folder in parent theme doesn't do anything.

I can use the filters mentioned here

https://support.advancedcustomfields.com/forums/topic/acf-json-fields-not-loading-from-parent-theme/

but that forces saves inside parent theme and my plugin fields are then ignored (which defeats the purpose. I found your plugin to solve this very issue)

TLDR, can you detect acf-json from parent theme also?

Not just the path.

Add an action log.

On my latest client site a FG got deleted unexpectedly by the plugin. I have no idea why it decided to do that. Luckily the FG was recoverable from Git.

A new JSON field group file triggers both the "delete it" and "sync it" function. The delete it function is faster. Find a way around this conflict.

I.e. missing WP_ENV, or no acf-json folders detected.

Is this plugin still supported? Also, is there potential for testing the new ACF 6.2 Multiple JSON compatibility? Just curious, thanks!

Hi,
just a suggestion here.

The Field Groups backend menu link has been removed on non-local environments to deter use. The page is still available however, if you visit the URL directly.

My opinion (prbably not worth much as im not half as talented a dev as you) is that I think this shouldn't be enforced. ACF already has an option for this.

Under installation instructions you specify that

Define WP_ENV as local on your local environment.

Hardcoding this value might put a lot of people off. I use development as my standard environment name, for instance. I suspect this would vary greatly depending on who you ask.

Wouldn't it be better if this value was configurable by the user?

Here's how I would implement it at first thought:
Create an options page accessed by a settings link in the plugin's entry in the list of installed plugins. Submitting a form on the options page would write its value to the wp_options table with a key like acf_agency_workflow_env.

I'll see if I can cook it up and send you a pull request.

If there's no acf-json folder in the active theme, that dir is still listed in acf_get_setting('load_json').

Choosing this location, or 'Default', will save the FG to the DB, but not to a JSON file. When you then return to the FG page, it gets deleted because of that.

How to reproduce:

Create a FG.
Open the JSON.
Change the title.
Change the modified timestamp to right now. (so it is newer and gets synced)
Save.
Load the dashboard or FG page.

poof

The JSON file is deleted.

Manually editing the JSON is not a primary feature but I think it should be possible. I assume it's also very similar to pulling in a changed JSON file from a coworker, which is a primary feature.

I initially wanted to include all of the ACF related add-ons and tweaks that my agency uses in this plugin. That's where the "agency workflow" name came from. With more features come more opinions, and with more opinions come more people that disagree. So to grow the popularity of the plugin, I now think it's probably better to keep it lean and simple.

For now:
It lets you store field groups in plugins and themes.
It lets you move field groups.
It auto syncs field groups.

What would be a better name?

Display a notice if a newer version is available on Github.

Updating like a dot-org plugin is a feature for later.

This might be totally out of scope or irrelevant for this plugin (please close the issue in that case), but at least it can be an idea since it kinda also elevates the agency workflow.

https://support.advancedcustomfields.com/forums/topic/reusable-flexible-layouts/

The idea would be actually to get to the point where flexible content layouts would act more or less like Gutenberg Blocks or even React Components - user could install a plugin which could provide custom post type, custom fields for the post type and basic styles and template for the flexible content layout. Of course, there should be a possibility to overwrite template and styles.

I know this sounds cheesy, but this could eventually lead to a little community which would share/open source the flexible layouts the same way the Gutenberg blocks are shared.

Hi,

Your plugin is amazing, exactly what I needed, just one question. is it production ready ? I'm planning to use as a mu plugin on a multisite network.

Thanks for the great job.