brry / dwdradar Goto Github PK

I forked the repo and added YW (radklim) to the list of products in the readradarfile function. See my pull request there...
lochbika#1

See brry/rdwd#6

there are two instances of Fortran code with the input parameter integer(KIND=2):

• https://github.com/brry/dwdradar/blob/master/src/binary_to_num.f90#L20
• https://github.com/brry/dwdradar/blob/master/src/binary_to_num.f90#L55

The CRAN team wrote to change that.

According to the Fortran standards, numerical values are just an enumeration.
What e.g. real(kind=4) means (or even if it is accepted) is implementation dependent.
Please change them to something portable.
kind(1.0) or kind(1.0d0} are commonly used, as is c_double from iso_c_binding.

There are differing(?) answers on stackoverflow that I don't understand:
https://stackoverflow.com/a/3170438

compare the reading function with other approaches. Is their code cleaner? faster?

• https://github.com/KWB-R/kwb.dwd
• https://rdrr.io/github/GeoinformationSystems/xtruso_R/src/R/Radolan.R
• https://moc.online.uni-marburg.de/doku.php?id=courses:bsc:project-thesis-geoei:lecture-notes:bdh:pt-ge-ln-bdh-01-9000
• https://gitlab.cs.fau.de/since/radolan

Reference git history at rdwd/R/readRadarFile.R

RY Files cannot yet be read. I get

Error in readBin(confile, what = raw(), n = n, endian = "little") : vector size cannot be NA/NaN

https://github.com/brry/dwdradar/blob/master/tests/testthat/test-readRadarFile.R#L35